From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDPqB-00041J-Pd for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:27:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDPq9-0001RW-T3 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:27:42 -0400 Date: Thu, 16 Jun 2016 13:27:29 +0800 From: Fam Zheng Message-ID: <20160616052729.GJ12178@ad.usersys.redhat.com> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-9-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465939839-30097-9-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 08/17] blkdebug: Set request_alignment during .bdrv_refresh_limits() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, Max Reitz On Tue, 06/14 15:30, Eric Blake wrote: > We want to eventually stick request_alignment alongside other > BlockLimits, but first, we must ensure it is populated at the > same time as all other limits, rather than being a special case > that is set only when a block is first opened. > > qemu-iotests 77 is particularly sensitive to the fact that we > can specify an artificial alignment override in blkdebug, and > that override must continue to work even when limits are > refreshed on an already open device. > > A later patch will be altering when bs->request_alignment > defaults are set, so fall back to sector alignment if we have > not inherited anything yet. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng