From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDQ4O-0004a4-Sg for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDQ4O-0004sP-0D for qemu-devel@nongnu.org; Thu, 16 Jun 2016 01:42:24 -0400 Date: Thu, 16 Jun 2016 13:42:11 +0800 From: Fam Zheng Message-ID: <20160616054211.GP12178@ad.usersys.redhat.com> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-15-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465939839-30097-15-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, Max Reitz , Stefan Hajnoczi , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven , "Michael S. Tsirkin" On Tue, 06/14 15:30, Eric Blake wrote: > Sector-based limits are awkward to think about; in our on-going > quest to move to byte-based interfaces, convert max_transfer_length > and opt_transfer_length. Rename them (dropping the _length suffix) > so that the compiler will help us catch the change in semantics > across any rebased code, and improve the documentation. Use unsigned > values, so that we don't have to worry about negative values and > so that bit-twiddling is easier; however, we are still constrained > by 2^31 of signed int in most APIs. > > Signed-off-by: Eric Blake Looks good apart from the scsi-generic blocksize calculation, which is not an issue of this patch. Reviewed-by: Fam Zheng