From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDcTa-0000QZ-C4 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 14:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDcTX-0005mv-7u for qemu-devel@nongnu.org; Thu, 16 Jun 2016 14:57:14 -0400 Received: from mail-yw0-x244.google.com ([2607:f8b0:4002:c05::244]:33358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDcTX-0005mr-3b for qemu-devel@nongnu.org; Thu, 16 Jun 2016 14:57:11 -0400 Received: by mail-yw0-x244.google.com with SMTP id d137so508319ywe.0 for ; Thu, 16 Jun 2016 11:57:10 -0700 (PDT) From: Pranith Kumar Date: Thu, 16 Jun 2016 14:56:39 -0400 Message-Id: <20160616185639.5312-1-bobby.prani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , "open list:All patches CC here" Using gcc 6.1 for alpha-linux-user target we see the following build error: /mnt/devops/code/qemu/target-alpha/translate.c: In function ‘in_superpage’: /mnt/devops/code/qemu/target-alpha/translate.c:454:52: error: self-comparison always evaluates to true [-Werror=tautological-compare] && addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); Fix it by replacing (addr >> 63) by '1' which is what it evaluates to since addr is negative. Signed-off-by: Pranith Kumar --- target-alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index f9b2426..31da6ea 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -451,7 +451,7 @@ static bool in_superpage(DisasContext *ctx, int64_t addr) return ((ctx->tb->flags & TB_FLAGS_USER_MODE) == 0 && addr < 0 && ((addr >> 41) & 3) == 2 - && addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); + && addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1); } static bool use_goto_tb(DisasContext *ctx, uint64_t dest) -- 2.9.0