From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46210)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bDhhX-0006LK-7D
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 20:32:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bDhhQ-0006XV-2Z
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 20:31:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bDhhP-0006XR-Sf
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 20:31:51 -0400
Date: Fri, 17 Jun 2016 03:31:48 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160617033021-mutt-send-email-mst@redhat.com>
References: <20160614225933-mutt-send-email-mst@redhat.com>
	<CAFEAcA-YZzidOD456=efnbdq+hiTavyRykY35E12GoTb_s3Xpg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-YZzidOD456=efnbdq+hiTavyRykY35E12GoTb_s3Xpg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features,
 cleanups, fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Corey Minyard <cminyard@mvista.com>

On Wed, Jun 15, 2016 at 04:11:30PM +0100, Peter Maydell wrote:
> On 14 June 2016 at 20:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> > changes from v1:
> >     - fixed up build on 32 bit
> >     - fixed up build on old glibc
> >
> > Peter, I could not reproduce the issue with noipmi that
> > you reported. Could it be a merge artifact?
> > I rebased to latest master to help avoid these.
> 
> No, this still fails on every machine and config I test on.
> 
> I suggest you just fix this to use the stub machinery
> which we already know works, rather than trying to
> debug whatever's going wrong with what you're trying.
> 
> Also, format string issues:
> 
> /home/petmay01/qemu/hw/acpi/nvdimm.c: In function 'nvdimm_rw_label_data_check':
> /home/petmay01/qemu/hw/acpi/nvdimm.c:568:9: error: format '%lx'
> expects argument of type 'long unsigned int', but arg
> ument 4 has type 'uint64_t' [-Werror=format=]
>          nvdimm_debug("position %#x is beyond label data (len = %#lx).\n",
>          ^
> 
> thanks
> -- PMM

I dropped these patchsets from pull request for now.
Submitters, pls fix it up and resubmit.

Thanks!

-- 
MST