Re: [Qemu-devel] [PATCH v2] ppc / sparc: Add a tester for checking whether OpenBIOS runs successfully

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

On Wed, Jun 15, 2016 at 01:10:18PM +1000, David Gibson wrote:
> On Tue, Jun 14, 2016 at 03:57:56PM +0200, Thomas Huth wrote:
> > Since the mac99 and g3beige PowerPC machines recently broke without
> > being noticed, it would be good to have a tester for "make check"
> > that detects such issues immediately. A simple way to test the firmware
> > of these machines is to use the "-prom-env" parameter of QEMU. This
> > parameter can be used to put some Forth code into the 'boot-command'
> > firmware variable which then can signal success to the tester by
> > writing a magic value to a known memory location. And since some of the
> > Sparc machines are also using OpenBIOS, they are now tested with this
> > prom-env-tester, too.
> > 
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  v2: Removed unnecessary include statements (as suggested by Markus)
> 
> Beautiful, I've applied this to ppc-for-2.7, assuming I don't get an
> objection to taking this through my tree.

Ugh.. turns out this fails on sparc64 target on a 32-bit x86 host.
Specifically it trips the tcg_abort() at the end of tcg_reg_alloc()
(tcg/tcg.c).

I'm reasonably confident this is a pre-existing bug, just triggered by
this test, but in the interests of getting this up and running on the
platforms where it is working, I've disabled the testcase on sparc64
for now.

Mark, if you could debug the sparc64-on-i386 failure at some point,
that would be helpful.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]