From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDoee-0006hS-A5 for qemu-devel@nongnu.org; Fri, 17 Jun 2016 03:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDoeb-0001fS-78 for qemu-devel@nongnu.org; Fri, 17 Jun 2016 03:57:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDoeb-0001fN-0z for qemu-devel@nongnu.org; Fri, 17 Jun 2016 03:57:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74A833710FA for ; Fri, 17 Jun 2016 07:57:24 +0000 (UTC) Date: Fri, 17 Jun 2016 09:57:21 +0200 From: Igor Mammedov Message-ID: <20160617095721.5edcebf9@nial.brq.redhat.com> In-Reply-To: <1464716918-29689-2-git-send-email-marcel@redhat.com> References: <1464716918-29689-1-git-send-email-marcel@redhat.com> <1464716918-29689-2-git-send-email-marcel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/7] hw/acpi: remove dead acpi code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com On Tue, 31 May 2016 20:48:32 +0300 Marcel Apfelbaum wrote: > PCST and PCSB operation regions are not used by the Q35 machine. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 279f0d7..9aef25d 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2016,16 +2016,6 @@ build_dsdt(GArray *table_data, GArray *linker, > build_piix4_pci0_int(dsdt); > } else { > sb_scope = aml_scope("_SB"); > - aml_append(sb_scope, > - aml_operation_region("PCST", AML_SYSTEM_IO, aml_int(0xae00), 0x0c)); > - aml_append(sb_scope, > - aml_operation_region("PCSB", AML_SYSTEM_IO, aml_int(0xae0c), 0x01)); > - field = aml_field("PCSB", AML_ANY_ACC, AML_NOLOCK, AML_WRITE_AS_ZEROS); > - aml_append(field, aml_named_field("PCIB", 8)); > - aml_append(sb_scope, field); > - aml_append(dsdt, sb_scope); > - > - sb_scope = aml_scope("_SB"); > dev = aml_device("PCI0"); > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08"))); > aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));