From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDrub-0000FG-TH for qemu-devel@nongnu.org; Fri, 17 Jun 2016 07:26:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDruZ-0007Dn-0H for qemu-devel@nongnu.org; Fri, 17 Jun 2016 07:26:07 -0400 Date: Fri, 17 Jun 2016 13:25:58 +0200 From: Kevin Wolf Message-ID: <20160617112558.GE5431@noname.redhat.com> References: <1466093381-6120-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466093381-6120-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v2 0/3] potentially broken drive-mirror/drive-backup in bdrv_co_discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Max Reitz Am 16.06.2016 um 18:09 hat Denis V. Lunev geschrieben: > Actually I have found this problem running iotest 132 for active async > mirror I have sent yesturday. Anyway, the problem is actual for current > backup/mirror implementation. > > bdrv_co_discard must mark areas dirty after writing zeroes, it must call > before_write_notifier chain to push underlying data to backup and it also > must properly fill tracked request information. > > Changes from v1: > - fixed problem in patch as pointed out by Vova > - ported to current (was made on top of active block mirror) > - minor spelling changes in commit messages > > Signed-off-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Fam Zheng > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Max Reitz Reviewed-by: Kevin Wolf