From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE7TO-0002YG-KH for qemu-devel@nongnu.org; Sat, 18 Jun 2016 00:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE7TN-0004eA-Lm for qemu-devel@nongnu.org; Sat, 18 Jun 2016 00:03:06 -0400 Date: Sat, 18 Jun 2016 14:02:46 +1000 From: Anton Blanchard Message-ID: <20160618140246.027e6887@kryten> In-Reply-To: <20160618002756.780936ac@kryten> References: <1464318298-2456-1-git-send-email-david@gibson.dropbear.id.au> <1464318298-2456-4-git-send-email-david@gibson.dropbear.id.au> <20160615221719.12f246dd@kryten> <20160616051928.GA1642@voom.fritz.box> <2fe8f40e-27ba-23b7-5d11-f75eda95568d@twiddle.net> <20160618002756.780936ac@kryten> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: David Gibson , peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org Hi, > > > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, > > > do you have a better idea how to fix it? > > > > Please try the following. > > Thanks! This passes my tests. Feel free to add: > > Tested-by: Anton Blanchard Actually I think I've found a problem: lis r4,0x7fffffff@h ori r4,r4,0x7fffffff@l rlwinm r3,r4,0,25,1 32 bit rotate is defined as a 64 bit rotate of 2 copies of the 32 bit value, so we expect 0x7fffffff4000007f, but get 0x4000007f. Not sure if anything out there depends on it though. Anton