From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bETLo-0004uX-Gj for qemu-devel@nongnu.org; Sat, 18 Jun 2016 23:24:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bETLj-0001D9-D3 for qemu-devel@nongnu.org; Sat, 18 Jun 2016 23:24:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bETLj-0001D5-4T for qemu-devel@nongnu.org; Sat, 18 Jun 2016 23:24:39 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C112663E12 for ; Sun, 19 Jun 2016 03:24:38 +0000 (UTC) Date: Sun, 19 Jun 2016 06:24:35 +0300 From: "Michael S. Tsirkin" Message-ID: <20160619062429-mutt-send-email-mst@redhat.com> References: <1466023310-13221-1-git-send-email-armbru@redhat.com> <1466023310-13221-2-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466023310-13221-2-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC 1/4] log: Clean up misuse of Range for -dfilter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, eblake@redhat.com, pbonzini@redhat.com On Wed, Jun 15, 2016 at 10:41:47PM +0200, Markus Armbruster wrote: > Range encodes an integer interval [a,b] as { begin = a, end = b + 1 }, > where a \in [0,2^64-1] and b \in [1,2^64]. Thus, zero end is to be > interpreted as 2^64. > > The implementation of -dfilter (commit 3514552) uses Range > differently: it encodes [a,b] as { begin = a, end = b }. The code > works, but it contradicts the specification of Range in range.h. > > Switch to the specified representation. Since it can't represent > [0,UINT64_MAX], we have to reject that now. Add a test for it. > > While we're rejecting anyway: observe that we reject -dfilter LOB..UPB > where LOB > UPB when UPB is zero, but happily create an empty Range > when it isn't. Reject it then, too, and add a test for it. > > While there, add a positive test for the problematic upper bound > UINT64_MAX. > > Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin > --- > tests/test-logging.c | 10 ++++++++++ > util/log.c | 28 +++++++++++++++------------- > 2 files changed, 25 insertions(+), 13 deletions(-) > > diff --git a/tests/test-logging.c b/tests/test-logging.c > index 440e75f..b6fa94e 100644 > --- a/tests/test-logging.c > +++ b/tests/test-logging.c > @@ -68,6 +68,16 @@ static void test_parse_range(void) > g_assert(qemu_log_in_addr_range(0x2050)); > g_assert(qemu_log_in_addr_range(0x3050)); > > + qemu_set_dfilter_ranges("0xffffffffffffffff-1", &error_abort); > + g_assert(qemu_log_in_addr_range(UINT64_MAX)); > + g_assert_false(qemu_log_in_addr_range(UINT64_MAX - 1)); > + > + qemu_set_dfilter_ranges("0..0xffffffffffffffff", &err); > + error_free_or_abort(&err); > + > + qemu_set_dfilter_ranges("2..1", &err); > + error_free_or_abort(&err); > + > qemu_set_dfilter_ranges("0x1000+onehundred", &err); > error_free_or_abort(&err); > > diff --git a/util/log.c b/util/log.c > index 32e4160..f811d61 100644 > --- a/util/log.c > +++ b/util/log.c > @@ -131,8 +131,8 @@ bool qemu_log_in_addr_range(uint64_t addr) > if (debug_regions) { > int i = 0; > for (i = 0; i < debug_regions->len; i++) { > - struct Range *range = &g_array_index(debug_regions, Range, i); > - if (addr >= range->begin && addr <= range->end) { > + Range *range = &g_array_index(debug_regions, Range, i); > + if (addr >= range->begin && addr <= range->end - 1) { > return true; > } > } > @@ -158,7 +158,7 @@ void qemu_set_dfilter_ranges(const char *filter_spec, Error **errp) > for (i = 0; ranges[i]; i++) { > const char *r = ranges[i]; > const char *range_op, *r2, *e; > - uint64_t r1val, r2val; > + uint64_t r1val, r2val, lob, upb; > struct Range range; > > range_op = strstr(r, "-"); > @@ -187,27 +187,29 @@ void qemu_set_dfilter_ranges(const char *filter_spec, Error **errp) > (int)(r2 - range_op), range_op); > goto out; > } > - if (r2val == 0) { > - error_setg(errp, "Invalid range"); > - goto out; > - } > > switch (*range_op) { > case '+': > - range.begin = r1val; > - range.end = r1val + (r2val - 1); > + lob = r1val; > + upb = r1val + r2val - 1; > break; > case '-': > - range.end = r1val; > - range.begin = r1val - (r2val - 1); > + upb = r1val; > + lob = r1val - (r2val - 1); > break; > case '.': > - range.begin = r1val; > - range.end = r2val; > + lob = r1val; > + upb = r2val; > break; > default: > g_assert_not_reached(); > } > + if (lob > upb || (lob == 0 && upb == UINT64_MAX)) { > + error_setg(errp, "Invalid range"); > + goto out; > + } > + range.begin = lob; > + range.end = upb + 1; > g_array_append_val(debug_regions, range); > } > out: > -- > 2.5.5