From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bExxL-0001Q1-Lv
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:05:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bExxF-00068B-HL
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:05:30 -0400
Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36057)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bExxF-000683-AK
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:05:25 -0400
Received: by mail-wm0-x243.google.com with SMTP id c82so10590893wme.3
	for <qemu-devel@nongnu.org>; Mon, 20 Jun 2016 05:05:25 -0700 (PDT)
Date: Mon, 20 Jun 2016 13:05:21 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160620120521.GA14100@stefanha-x1.localdomain>
References: <146590985033.16561.16324808287190305042.stgit@fimbulvetr.bsc.es>
	<146590987194.16561.5003247869378936017.stgit@fimbulvetr.bsc.es>
	<20160617152432.GL28550@stefanha-x1.localdomain>
	<87shwb371i.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy"
Content-Disposition: inline
In-Reply-To: <87shwb371i.fsf@fimbulvetr.bsc.es>
Subject: Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states
 for events with the 'vcpu' property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>


--KsGdsel6WgEHnImy
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 17, 2016 at 10:16:25PM +0200, Llu=EDs Vilanova wrote:
> Stefan Hajnoczi writes:
>=20
> > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Llu=EDs Vilanova wrote:
> >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv)
> >> gdbserver_start (gdbstub_port);
> >> gdb_handlesig(cpu, 0);
> >> }
> >> +    trace_init_vcpu_events();
>=20
> > Do vcpu events make sense in *-user builds?  I thought this feature is
> > only available in *-softmmu.
>=20
> It's here for completeness, although it's currently useless. AFAIK, QEMU =
has
> multiple vCPUs when the user application is multi-threaded, but user QEMU=
 has no
> interface to interactively control event states.

Yes, please drop the *-user changes.  I see no trace_init_*() calls in
*-user so it won't be useful to call trace_init_vcpu_events().

Stefan

--KsGdsel6WgEHnImy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXZ9wBAAoJEJykq7OBq3PICmwH/iFJEVVDoEY99LotU/AW4YVn
XEJlWkOoLBKEDtXSz7HW9T+BTKRLg77zKaCEwpKfJcJkQfZAecYtqKE5MqZ+o7Mv
0gpRMHSxwL98FKcAHTy0u68xwgfgGQcA0nxgfYvVt+NY/JjTiRQnR/Vn48jjxKTT
N66m4oscrdX+YbG2SVlxJhtQpM4wJ6RgD3+kJ2GVk4NZkLsT1o12WUm4FeY2yLJU
61GlfLsBAAqleI6jvsqJ5n2dvvifjd0U8F7DiSyRPtECWWkvF7LN8moHSeM1fgOD
50UD2RXPgMlYfmwSoioAxsC1o/G0/9dncnrbpX3FFjplfYLdjvXDeiNRxPBE5W4=
=XTuk
-----END PGP SIGNATURE-----

--KsGdsel6WgEHnImy--