From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bEy2f-00056S-GZ
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:11:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bEy2Z-00076y-Bd
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:11:00 -0400
Date: Mon, 20 Jun 2016 13:10:52 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160620121052.GC14100@stefanha-x1.localdomain>
References: <1465939839-30097-1-git-send-email-eblake@redhat.com>
	<1465939839-30097-3-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG"
Content-Disposition: inline
In-Reply-To: <1465939839-30097-3-git-send-email-eblake@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] block: Document
 supported flags during bdrv_aligned_preadv()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, Fam Zheng <famz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>


--XMCwj5IQnwKtuyBG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 14, 2016 at 03:30:24PM -0600, Eric Blake wrote:
> We don't pass any flags on to drivers to handle.  Tighten an
> assert to explain why we pass 0 to bdrv_driver_preadv(), and add
> some comments on things to be aware of if we want to turn on
> per-BDS BDRV_REQ_FUA support during reads in the future.  Also,
> document that we may want to consider using unmap during
> copy-on-read operations where the read is all zeroes.
>=20
> Signed-off-by: Eric Blake <eblake@redhat.com>
>=20
> ---
> v2: retitle from 'Honor flags during bdrv_aligned_preadv()', and
> change scope of patch
> ---
>  block/io.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--XMCwj5IQnwKtuyBG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXZ91MAAoJEJykq7OBq3PI+60IALNztObP34G0hR5NpOn4eHmY
EkkPRVSWw83AOTCYNajzeSA5be91k/kFj+ZNAJED8WF19EvmnUdoYWsIkKzWSfJI
zmDUq4lOraK4cJwGp8pM1BDFAdo1lZO0bfIV1wy3tPO2HEEvV5Dzt/uSl9Q9gW9e
sAMajovGVYtz0IpYw0q4hn5QXFx1VUyJbTJ91S3zXY2YpApKWS/BJiepsQTzadhx
wjy0J50JTq3JKABURFhVmRFKCjgSdvkVMekgtHSGNvkV5q1MJvcKb2zqJWaopNzz
z/DVdWB8xl7A9XLLwjRy12vTHI2N0ZOaYj2Giyvvz+oHygoLwf2u6/zfk9NwOfA=
=qn/+
-----END PGP SIGNATURE-----

--XMCwj5IQnwKtuyBG--