From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEy5R-0007xM-5j for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:13:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEy5G-0007YS-Rk for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:13:52 -0400 Date: Mon, 20 Jun 2016 13:13:40 +0100 From: Stefan Hajnoczi Message-ID: <20160620121340.GE14100@stefanha-x1.localdomain> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-5-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="maH1Gajj2nflutpK" Content-Disposition: inline In-Reply-To: <1465939839-30097-5-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, Paolo Bonzini , qemu-block@nongnu.org, Max Reitz --maH1Gajj2nflutpK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2016 at 03:30:26PM -0600, Eric Blake wrote: > The NBD layer was breaking up request at a limit of 2040 sectors > (just under 1M) to cater to old qemu-nbd. But the server limit > was raised to 32M in commit 2d8214885 to match the kernel, more > than three years ago; and the upstream NBD Protocol is proposing > documentation that without any explicit communication to state > otherwise, a client should be able to safely assume that a 32M > transaction will work. It is time to rely on the larger sizing, > and any downstream distro that cares about maximum > interoperability to older qemu-nbd servers can just tweak the > value of #define NBD_MAX_SECTORS. >=20 > Signed-off-by: Eric Blake >=20 > --- > v2: new patch > --- > include/block/nbd.h | 1 + > block/nbd-client.c | 4 ---- > 2 files changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi --maH1Gajj2nflutpK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXZ930AAoJEJykq7OBq3PIYoUH/A+6Ly8jKvyAT81WRppAdTvd 41h0JK0CGMD9Ke0b6LqUjCfxk1+ClXSBU4GJrl/qOlwjBDAmUINJEPEFg1e+cf0b vxV2U4/y1IUH/mzTwp4fSU+K30pd4PDK3WHJzJMXc1/RtR2fx7H+sMcsPd+mhbKB udjdQUtWwOuhGjxDd0BqcTj0iVCrWgO3Idy4tq2xazdcUiPE+kIjUDt3bKUl+b4W MP8lpGpWowl/yX9ZHpKXROJP/UY/tefSDu0RWpK6w4TiVOxv2x9ZKwWcNB00QZJ0 08TdIEc3NihexOIXoAVsr1FoTtUd1ZvidaGangv/1YVvaJXEbyhAzhg6nK5hRgo= =9SO2 -----END PGP SIGNATURE----- --maH1Gajj2nflutpK--