From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEy7h-0001Oi-GX for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:16:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEy7c-00087K-9d for qemu-devel@nongnu.org; Mon, 20 Jun 2016 08:16:12 -0400 Date: Mon, 20 Jun 2016 13:16:05 +0100 From: Stefan Hajnoczi Message-ID: <20160620121605.GG14100@stefanha-x1.localdomain> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> <1465939839-30097-7-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p7qwJlK53pWzbayA" Content-Disposition: inline In-Reply-To: <1465939839-30097-7-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/17] iscsi: Advertise realistic limits to block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, Peter Lieven , Max Reitz , Ronnie Sahlberg , Paolo Bonzini --p7qwJlK53pWzbayA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2016 at 03:30:28PM -0600, Eric Blake wrote: > The function sector_limits_lun2qemu() returns a value in units of > the block layer's 512-byte sector, and can be as large as > 0x40000000, which is much larger than the block layer's inherent > limit of BDRV_REQUEST_MAX_SECTORS. The block layer already > handles '0' as a synonym to the inherent limit, and it is nicer > to return this value than it is to calculate an arbitrary > maximum, for two reasons: we want to ensure that the block layer > continues to special-case '0' as 'no limit beyond the inherent > limits'; and we want to be able to someday expand the block > layer to allow 64-bit limits, where auditing for uses of > BDRV_REQUEST_MAX_SECTORS will help us make sure we aren't > artificially constraining iscsi to old block layer limits. >=20 > Signed-off-by: Eric Blake >=20 > --- > v2: new patch > --- > block/iscsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi --p7qwJlK53pWzbayA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXZ96FAAoJEJykq7OBq3PIoCYH+wYurl8+Lo1UAXdQKcvCFZgj +Ru79Q36hJzUAZD279q+oQMQrT0QHPZMm70ufvOAz9XdKa0+mMlquAhvnexg8g9T AMz9ftEp0iqpkhvoI7TKF/0SLaMrybUJf12VNHhqy1F+wu3qpm30Q+UP9Qd3Jpkd gAouGBjsZYLQFLAAgJ+/ovz7AlWKezRQ7FLBdUD9AOQ/wSvK6mi2A45vkxNxcQEb kb80QvPdA2MOviSHVwqor4E21KhVWYNu5cpwhc2lYrjMJrw6FsOSkhmyAd9bGKX7 f18sYZnwUytCxr5i0UfiN4k7yfzKpNeTQcFgJRs43t/Gs8EIXIp+ZyfQHWsGDrw= =rd0R -----END PGP SIGNATURE----- --p7qwJlK53pWzbayA--