From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEyyw-00065W-Vm for qemu-devel@nongnu.org; Mon, 20 Jun 2016 09:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEyyr-00035v-45 for qemu-devel@nongnu.org; Mon, 20 Jun 2016 09:11:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEyyq-00035C-UB for qemu-devel@nongnu.org; Mon, 20 Jun 2016 09:11:09 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 261DC8E37D for ; Mon, 20 Jun 2016 13:11:06 +0000 (UTC) Date: Mon, 20 Jun 2016 15:11:00 +0200 From: Igor Mammedov Message-ID: <20160620151100.20e478d5@igors-macbook-pro.local> In-Reply-To: <1466022773-8965-1-git-send-email-ehabkost@redhat.com> References: <1466022773-8965-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster , Marcel Apfelbaum , Paolo Bonzini On Wed, 15 Jun 2016 17:32:43 -0300 Eduardo Habkost wrote: > This series includes multiple changes to the way errors are > handled by the global property system. Could you fix "make check", by the end of series it breaks at compile time. > > The series is based on my machine-next branch, available at: > https://github.com/ehabkost/qemu.git machine-next > > The series itself can be found at: > https://github.com/ehabkost/qemu-hacks.git > work/global-error-handling > > Eduardo Habkost (10): > qdev: Don't stop applying globals on first error > qdev: Eliminate qemu_add_globals() function > vl: Reject invalid class names on -global > qdev: Use error_prepend() for errors applying globals > qdev: GlobalProperty.errp field > machine: Add machine_register_compat_props() function > vl: Set errp to &error_abort on machine compat_props > qdev: Eliminate "global not used" warning > qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields > machine: Skip global registration for non-existing classes > > hw/core/machine.c | 27 +++++++++++++++++++++++ > hw/core/qdev-properties-system.c | 21 +----------------- > hw/core/qdev-properties.c | 46 > ++++++---------------------------------- > include/hw/boards.h | 1 + > include/hw/qdev-core.h | 9 ++++---- > include/hw/qdev-properties.h | 1 - > include/qemu/config-file.h | 1 - > vl.c | 38 > ++++++++++++++++++++++++++------- 8 files changed, 70 insertions(+), > 74 deletions(-) >