From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFMW9-0001je-Ev for qemu-devel@nongnu.org; Tue, 21 Jun 2016 10:19:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFMW4-0008PN-Ee for qemu-devel@nongnu.org; Tue, 21 Jun 2016 10:19:04 -0400 Date: Tue, 21 Jun 2016 16:18:50 +0200 From: Kevin Wolf Message-ID: <20160621141850.GK4520@noname.redhat.com> References: <1465939839-30097-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465939839-30097-1-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/17] Byte-based block limits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Am 14.06.2016 um 23:30 hat Eric Blake geschrieben: > BlockLimits is currently an ugly mix of byte limits vs. > sector limits. Unify it. Fix some bugs I found in > bdrv_aligned_preadv() while at it. > > Prequisite: Kevin's ongoing work to migrate bdrv_aligned_preadv() > to be byte-based (commit 3de06b2 on his vmstate branch at the > time of this email, but that gets rebased): > https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg02832.html > > Trivial contextual conflict in nbd.h with the pull request Paolo > will soon be posting (both series add a #define near the same > line; resolution is to add both): > https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg03333.html > > Also available as a tag at: > git fetch git://repo.or.cz/qemu/ericb.git nbd-limits-v2 I had a few minor comments, but this is really close. Patches 1-7 and 9-13 are: Reviewed-by: Kevin Wolf Kevin