From: David Hildenbrand <dahi@linux.vnet.ibm.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Jiri Denemark <jdenemar@redhat.com>,
libvir-list@redhat.com, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] qmp: query-host-cpu command
Date: Tue, 21 Jun 2016 14:52:54 +0200 [thread overview]
Message-ID: <20160621145254.7c982019@thinkpad-w530> (raw)
In-Reply-To: <20160621124542.GF2048@thinpad.lan.raisama.net>
> On Tue, Jun 21, 2016 at 08:20:40AM +0200, David Hildenbrand wrote:
> > > Add QMP command to allow management software to query for
> > > CPU information for the running host.
> > >
> > > The data returned by the command is in the form of a dictionary
> > > of QOM properties.
> > >
> > > This series depends on the "Add runnability info to
> > > query-cpu-definitions" series I sent 2 weeks ago.
> > >
> > > Git tree:
> > > https://github.com/ehabkost/qemu-hacks.git work/query-host-cpu
> > >
> >
> > I like that interface, I'm going to post (maybe today? :) ) a similar interface
> > that allows to also expand other cpu models, not just the host model.
>
> In x86 I want to avoid exposing the details of other CPU models
> to libvirt because the details depend on machine-type.
>
> But if it is useful for you, I believe the same "qom-properties"
> dict could be returned in query-cpu-definitions.
>
> >
> > Maybe we can then decide which one makes sense for all of us. But in general,
> > this interface is much better compared to what we had before.
>
> Maybe both? I think it's better to have a separate interface for
> querying "what exactly this host supports" and another one for
> querying for "what happens if I use -cpu host". In the case of
> x86, both are equivalent, but we can't guarantee this on all
> architectures.
>
I'll post my patches in a couple of minutes, let's discuss it then.
We might want to avoid having multiple interfaces carrying out the same task.
David
next prev parent reply other threads:[~2016-06-21 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 20:12 [Qemu-devel] [PATCH 0/3] qmp: query-host-cpu command Eduardo Habkost
2016-06-20 20:12 ` [Qemu-devel] [PATCH 1/3] qmp: Add " Eduardo Habkost
2016-06-21 21:48 ` Eric Blake
2016-06-23 16:37 ` Eduardo Habkost
2016-06-20 20:12 ` [Qemu-devel] [PATCH 2/3] target-i386: Introduce x86_cpu_load_host_data() function Eduardo Habkost
2016-06-23 14:59 ` Igor Mammedov
2016-06-23 16:04 ` Eduardo Habkost
2016-06-23 16:56 ` Igor Mammedov
2016-06-23 19:16 ` Eduardo Habkost
2016-06-20 20:12 ` [Qemu-devel] [PATCH 3/3] target-i386: Implement arch_query_host_cpu_info() Eduardo Habkost
2016-06-21 6:20 ` [Qemu-devel] [PATCH 0/3] qmp: query-host-cpu command David Hildenbrand
2016-06-21 12:45 ` Eduardo Habkost
2016-06-21 12:52 ` David Hildenbrand [this message]
2016-06-21 16:15 ` Eduardo Habkost
2016-06-21 17:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621145254.7c982019@thinkpad-w530 \
--to=dahi@linux.vnet.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).