From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFLAy-0004dd-0h for qemu-devel@nongnu.org; Tue, 21 Jun 2016 08:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFLAt-0005KL-P9 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 08:53:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:62796 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFLAt-0005KC-Je for qemu-devel@nongnu.org; Tue, 21 Jun 2016 08:53:03 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5LCn7Ui086202 for ; Tue, 21 Jun 2016 08:53:02 -0400 Received: from e06smtp16.uk.ibm.com (e06smtp16.uk.ibm.com [195.75.94.112]) by mx0b-001b2d01.pphosted.com with ESMTP id 23n0etne8a-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 21 Jun 2016 08:53:02 -0400 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Jun 2016 13:53:00 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 531BA17D8042 for ; Tue, 21 Jun 2016 13:54:13 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5LCquCi14156244 for ; Tue, 21 Jun 2016 12:52:56 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u5LCqunt021817 for ; Tue, 21 Jun 2016 06:52:56 -0600 Date: Tue, 21 Jun 2016 14:52:54 +0200 From: David Hildenbrand In-Reply-To: <20160621124542.GF2048@thinpad.lan.raisama.net> References: <1466453564-7572-1-git-send-email-ehabkost@redhat.com> <20160621082040.57c15988@thinkpad-w530> <20160621124542.GF2048@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160621145254.7c982019@thinkpad-w530> Subject: Re: [Qemu-devel] [PATCH 0/3] qmp: query-host-cpu command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Jiri Denemark , libvir-list@redhat.com, Igor Mammedov > On Tue, Jun 21, 2016 at 08:20:40AM +0200, David Hildenbrand wrote: > > > Add QMP command to allow management software to query for > > > CPU information for the running host. > > > > > > The data returned by the command is in the form of a dictionary > > > of QOM properties. > > > > > > This series depends on the "Add runnability info to > > > query-cpu-definitions" series I sent 2 weeks ago. > > > > > > Git tree: > > > https://github.com/ehabkost/qemu-hacks.git work/query-host-cpu > > > > > > > I like that interface, I'm going to post (maybe today? :) ) a similar interface > > that allows to also expand other cpu models, not just the host model. > > In x86 I want to avoid exposing the details of other CPU models > to libvirt because the details depend on machine-type. > > But if it is useful for you, I believe the same "qom-properties" > dict could be returned in query-cpu-definitions. > > > > > Maybe we can then decide which one makes sense for all of us. But in general, > > this interface is much better compared to what we had before. > > Maybe both? I think it's better to have a separate interface for > querying "what exactly this host supports" and another one for > querying for "what happens if I use -cpu host". In the case of > x86, both are equivalent, but we can't guarantee this on all > architectures. > I'll post my patches in a couple of minutes, let's discuss it then. We might want to avoid having multiple interfaces carrying out the same task. David