From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOL4-0002ph-0I for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOL0-0001ez-56 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:15:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOKz-0001eq-MI for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:15:41 -0400 Date: Tue, 21 Jun 2016 13:15:38 -0300 From: Eduardo Habkost Message-ID: <20160621161538.GH2048@thinpad.lan.raisama.net> References: <1466453564-7572-1-git-send-email-ehabkost@redhat.com> <20160621082040.57c15988@thinkpad-w530> <20160621124542.GF2048@thinpad.lan.raisama.net> <20160621145254.7c982019@thinkpad-w530> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160621145254.7c982019@thinkpad-w530> Subject: Re: [Qemu-devel] [PATCH 0/3] qmp: query-host-cpu command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, Jiri Denemark , libvir-list@redhat.com, Igor Mammedov On Tue, Jun 21, 2016 at 02:52:54PM +0200, David Hildenbrand wrote: > > On Tue, Jun 21, 2016 at 08:20:40AM +0200, David Hildenbrand wrote: > > > > Add QMP command to allow management software to query for > > > > CPU information for the running host. > > > > > > > > The data returned by the command is in the form of a dictionary > > > > of QOM properties. > > > > > > > > This series depends on the "Add runnability info to > > > > query-cpu-definitions" series I sent 2 weeks ago. > > > > > > > > Git tree: > > > > https://github.com/ehabkost/qemu-hacks.git work/query-host-cpu > > > > > > > > > > I like that interface, I'm going to post (maybe today? :) ) a similar interface > > > that allows to also expand other cpu models, not just the host model. > > > > In x86 I want to avoid exposing the details of other CPU models > > to libvirt because the details depend on machine-type. > > > > But if it is useful for you, I believe the same "qom-properties" > > dict could be returned in query-cpu-definitions. > > > > > > > > Maybe we can then decide which one makes sense for all of us. But in general, > > > this interface is much better compared to what we had before. > > > > Maybe both? I think it's better to have a separate interface for > > querying "what exactly this host supports" and another one for > > querying for "what happens if I use -cpu host". In the case of > > x86, both are equivalent, but we can't guarantee this on all > > architectures. > > > > I'll post my patches in a couple of minutes, let's discuss it > then. > > We might want to avoid having multiple interfaces carrying out > the same task. OK, I will wait for the patches before discussing it. My assumption is that both look similar, but are actually different tasks. -- Eduardo