From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFc5b-0005uu-7V for qemu-devel@nongnu.org; Wed, 22 Jun 2016 02:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFc5W-0006sp-9d for qemu-devel@nongnu.org; Wed, 22 Jun 2016 02:56:42 -0400 Date: Wed, 22 Jun 2016 16:57:46 +1000 From: David Gibson Message-ID: <20160622065746.GQ17957@voom.fritz.box> References: <1466545735-2555-1-git-send-email-clg@kaod.org> <1466545735-2555-10-git-send-email-clg@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CfiwpigK2vfmwpN3" Content-Disposition: inline In-Reply-To: <1466545735-2555-10-git-send-email-clg@kaod.org> Subject: Re: [Qemu-devel] [PATCH v2 09/10] ppc: Move exception generation code out of line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, Benjamin Herrenschmidt --CfiwpigK2vfmwpN3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2016 at 11:48:54PM +0200, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > There's no point inlining this, if you hit the exception case you exit > anyway, and not inlining saves about 100K of code size (and cache > footprint). >=20 > Signed-off-by: Benjamin Herrenschmidt > [clg: removed '__attribute__((noinline))' from original patch ] > Signed-off-by: C=E9dric Le Goater Reviewed-by: David Gibson > --- > target-ppc/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 83ec2dd7707b..365fe3d34461 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -283,7 +283,7 @@ void gen_update_current_nip(void *opaque) > tcg_gen_movi_tl(cpu_nip, ctx->nip); > } > =20 > -static inline void gen_exception_err(DisasContext *ctx, uint32_t excp, u= int32_t error) > +static void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t= error) > { > TCGv_i32 t0, t1; > if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { > @@ -297,7 +297,7 @@ static inline void gen_exception_err(DisasContext *ct= x, uint32_t excp, uint32_t > ctx->exception =3D (excp); > } > =20 > -static inline void gen_exception(DisasContext *ctx, uint32_t excp) > +static void gen_exception(DisasContext *ctx, uint32_t excp) > { > TCGv_i32 t0; > if (ctx->exception =3D=3D POWERPC_EXCP_NONE) { > @@ -309,7 +309,7 @@ static inline void gen_exception(DisasContext *ctx, u= int32_t excp) > ctx->exception =3D (excp); > } > =20 > -static inline void gen_debug_exception(DisasContext *ctx) > +static void gen_debug_exception(DisasContext *ctx) > { > TCGv_i32 t0; > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --CfiwpigK2vfmwpN3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXajbqAAoJEGw4ysog2bOSvfwQAMh/lHYzKhBg0nKpir+GzfGe yXe7t6nD7GljUj9HOs/aWCHLSKmKDXPsHF1FLoG350Jp2KBE3VH+CgZFGTIzTC44 HrFN6jRMJVxrAcQzXacY0RhR2tTvQzCjz/6Z7dXcahqbWzYOPwOMML4iaWIVS+mn kV0/wMP+uBLQwVeAumie/rNUhTX8xMsymiHFB5Y7Oo+V0LwGNoZctLDtaCkjNrYX WJlZx2Ieus99lsDRiWv0syoJ1hp6113958dffpDxhgIRfiAOcwy2oNZ64097ceCS zFZYyKtvfXUQhN6sOD5OcNi0Dt+o5qYAokr9UtO4EAXSEyg4SGiQAjhJTNlHLnqK cdJIFj5rIVQXwR/rAXk0umGhrsWV3eoslI46Qolzz5W4vk0PvpbxQ527L9LruyHP v5/K3Hm0fvUdasVUzR3R7kcAE7XNTRLf+wcXKPrvHMoQfrO6KufQmd35pfigpQuj r/OxP03Ccbx3VdT+SwTGD0nmCFDmQn4WKJ3lDl3ILFvkh4Wa/5lgGVmlSFgc1YB1 4pytNGLoBkGYT+TB6lZHYbe1YKtleG4ORare5fGL/Y2yImdWJsEmKAw8UJfA4IyR I9cZwK+c4dYn2EBYLuuvd1LV/abPrvs0MWoTXoBgVaJMpNlpq616jg0zvkQuZ6WU 6P8qMPTB8wmTcWgLdJKN =4zOg -----END PGP SIGNATURE----- --CfiwpigK2vfmwpN3--