From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-ppc@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] ppc: Disable huge page support if it is not available for main RAM
Date: Thu, 23 Jun 2016 12:58:55 +1000 [thread overview]
Message-ID: <20160623025855.GV17957@voom.fritz.box> (raw)
In-Reply-To: <1466585405-3769-1-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
On Wed, Jun 22, 2016 at 10:50:05AM +0200, Thomas Huth wrote:
> On powerpc, we must only signal huge page support to the guest if
> all memory areas are capable of supporting huge pages. The commit
> 2d103aae8765 ("fix hugepage support when using memory-backend-file")
> already fixed the case when the user specified the mem-path property
> for NUMA memory nodes instead of using the global "-mem-path" option.
> However, there is one more case where it currently can go wrong.
> When specifying additional memory DIMMs without using NUMA, e.g.
>
> qemu-system-ppc64 -enable-kvm ... -m 1G,slots=2,maxmem=2G \
> -device pc-dimm,id=dimm-mem1,memdev=mem1 -object \
> memory-backend-file,policy=default,mem-path=/...,size=1G,id=mem1
>
> the code in getrampagesize() currently assumes that huge pages
> are possible since they are enabled for the mem1 object. But
> since the main RAM is not backed by a huge page filesystem,
> the guest Linux kernel then crashes very quickly after being
> started. So in case the we've got "normal" memory without NUMA
> and without the global "-mem-path" option, we must not announce
> huge pages to the guest. Since this is likely a mis-configuration
> by the user, also spill out a message in this case.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Applied to ppc-for-2.7.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-23 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 8:50 [Qemu-devel] [PATCH] ppc: Disable huge page support if it is not available for main RAM Thomas Huth
2016-06-23 2:58 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623025855.GV17957@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).