From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG13d-0007D4-M8 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG13Y-00082l-UV for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG13Y-00082h-PQ for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60A5785542 for ; Thu, 23 Jun 2016 09:36:16 +0000 (UTC) Date: Thu, 23 Jun 2016 10:36:13 +0100 From: "Daniel P. Berrange" Message-ID: <20160623093612.GK17868@redhat.com> Reply-To: "Daniel P. Berrange" References: <1466105332-10285-1-git-send-email-marcandre.lureau@redhat.com> <1466105332-10285-4-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1466105332-10285-4-git-send-email-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, pbonzini@redhat.com On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lureau@redhat.com wro= te: > From: Marc-Andr=C3=A9 Lureau >=20 > qemu leaves unix socket files behind when removing a listening chardev > or leaving. qemu could clean that up, even if doing so isn't race-free. >=20 > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1347077 >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > include/qemu/sockets.h | 1 + > io/channel-socket.c | 10 ++++++++++ > tests/test-io-channel-socket.c | 2 +- > util/qemu-sockets.c | 18 ++++++++++++++++++ > 4 files changed, 30 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|