From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG13u-0007PM-CC for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG13p-000884-MD for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG13p-00087z-G7 for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:36:33 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1CF90C04B328 for ; Thu, 23 Jun 2016 09:36:33 +0000 (UTC) Date: Thu, 23 Jun 2016 10:36:29 +0100 From: "Daniel P. Berrange" Message-ID: <20160623093629.GL17868@redhat.com> Reply-To: "Daniel P. Berrange" References: <1466105332-10285-1-git-send-email-marcandre.lureau@redhat.com> <0b4f08f7-f84d-c069-a702-d83e8cda8a20@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0b4f08f7-f84d-c069-a702-d83e8cda8a20@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] chardev cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org On Fri, Jun 17, 2016 at 02:34:41PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 16/06/2016 21:28, marcandre.lureau@redhat.com wrote: > > From: Marc-Andr=C3=A9 Lureau > >=20 > > Hi > >=20 > > A small series to do some chardev cleanup when removing them and > > leaving qemu. > >=20 > > Fixes: > > https://bugzilla.redhat.com/show_bug.cgi?id=3D1347077 > >=20 > > v1->v2: > > - use atexit() for qemu_chr_cleanup() > > - add missing braces > >=20 > > Marc-Andr=C3=A9 Lureau (3): > > char: clean up remaining chardevs when leaving > > socket: add listen feature > > socket: unlink unix socket on remove > >=20 > > include/io/channel.h | 1 + > > include/qemu/sockets.h | 1 + > > io/channel-socket.c | 17 +++++++++++++++++ > > qemu-char.c | 11 +++++++++++ > > tests/test-io-channel-socket.c | 2 +- > > util/qemu-sockets.c | 18 ++++++++++++++++++ > > 6 files changed, 49 insertions(+), 1 deletion(-) > >=20 >=20 > Looks good, I'll queue them if Dan acks patch 2. Go ahead, its all fine with me. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|