From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bG34T-0007Dd-I3
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 07:45:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bG34P-0006cs-Dj
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 07:45:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bG34P-0006bx-69
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 07:45:17 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 9B256C04B315
	for <qemu-devel@nongnu.org>; Thu, 23 Jun 2016 11:45:16 +0000 (UTC)
Date: Thu, 23 Jun 2016 08:45:15 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20160623114515.GO17952@thinpad.lan.raisama.net>
References: <1466437983-27133-1-git-send-email-ehabkost@redhat.com>
	<1466437983-27133-4-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466437983-27133-4-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on
 -global
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

On Mon, Jun 20, 2016 at 12:52:56PM -0300, Eduardo Habkost wrote:
> Instead of just printing a warning very late, reject obviously
> invalid -global arguments by validating the class name.
> 
> Update test-qdev-global-props to not expect class name validation
> to be performed in qdev_prop_check_globals().

Added the following to the commit message:

  The checks for the warnings in tests/test-qdev-global-props.c
  are being removed. Unfortunately, adding unit tests for vl.c
  would be quite difficult.

> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Fix test-qdev-global-props unit test
> * Simplify object_dynamic_cast() check
>   * Suggested-by: Markus Armbruster <armbru@redhat.com>

-- 
Eduardo