From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGH4U-0007bk-9I for qemu-devel@nongnu.org; Thu, 23 Jun 2016 22:42:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGH4P-0002De-Vs for qemu-devel@nongnu.org; Thu, 23 Jun 2016 22:42:17 -0400 Date: Fri, 24 Jun 2016 12:27:41 +1000 From: David Gibson Message-ID: <20160624022741.GA15625@voom.fritz.box> References: <201606232235.u5NMZHkU027326@linux03a.ddci.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <201606232235.u5NMZHkU027326@linux03a.ddci.com> Subject: Re: [Qemu-devel] [PATCH] target-ppc: ppce500_spin.c uses SPR_PIR, should use SPR_BOOKE_PIR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aaron Larson Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2016 at 03:35:17PM -0700, Aaron Larson wrote: >=20 > ppce500_spin.c uses SPR_PIR to initialize the spin table, however on > Book E processors the correct SPR is SPR_BOOKE_PIR. >=20 > Signed-off-by: Aaron Larson Applied to ppc-for-2.7, thanks. IIRC this leaves a redundant bit in spin_init, but that can be cleaned up later. > --- > hw/ppc/ppce500_spin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/ppce500_spin.c b/hw/ppc/ppce500_spin.c > index 76bd78b..225177b 100644 > --- a/hw/ppc/ppce500_spin.c > +++ b/hw/ppc/ppce500_spin.c > @@ -104,7 +104,7 @@ static void spin_kick(void *data) > hwaddr map_start; > =20 > cpu_synchronize_state(cpu); > - stl_p(&curspin->pir, env->spr[SPR_PIR]); > + stl_p(&curspin->pir, env->spr[SPR_BOOKE_PIR]); > env->nip =3D ldq_p(&curspin->addr) & (map_size - 1); > env->gpr[3] =3D ldq_p(&curspin->r3); > env->gpr[4] =3D 0; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXbJqdAAoJEGw4ysog2bOSk3MP/R4ax0Cn7kEGdg/iZ5qx7zbG w22fYRSrkaDz78y/TqPJHsJN/EvYjpWbk2PGdeI1JqSKQ8D/AqyuhtAWjXBBVKdy Zk5jpCj8I3Mes5oMGwwq6JTLwf/hOMNKQ/lJsPTNuT1yjM8zWOHck9FWE9RkYk53 KbnIWejId1+Pyhu2a8WyuLnOK73IZn7AmFp5BvmVPPANSyDUh2rEqdmTkhcDJ99I /nrh/FXB3sJZqIVog590tvD7l90h2ndS+5nfxUmh8oIlRvAMgds/c9ucstSMH56y DmVCZ1mU7HBJ9CyA+dxcJjGy9pBNYaPH4YaE7c6qcpeT7E0GAhytXRQ8KyqFPW5U fUIZ8LWocs/8Oak3MaSCRrAWNWZjwMdO6UKdUlV2tg2v6mjLzu+poID4ObS/70pW BStKOPFhS9uucote+2mT5/T17ORhjWBpPgoXGsO38ygVPnAbwqccS5aVAgMQf2qu wyxlMeGObBzuSql5ofN1jjW52NMqS+m/WvgEen3/4qyIfWKkcFi9LJ6CelhLRzZp uVGMDtktKmLW/L+JLFPI8xRMnOpZ1Uw1Yos0MfW0Qype5KbFc5g9CwdMCicydyaw ecnoGYr7onKA4sAu5nE0KhqBp5M9vU0gwJ7Ajwlqzy4k+QQBuOrspE5hBh+EK9x6 epdooLFkFI8shc5jfzoT =iWbl -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--