From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGJvY-0008Uf-SJ for qemu-devel@nongnu.org; Fri, 24 Jun 2016 01:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGJvW-0003nB-Oo for qemu-devel@nongnu.org; Fri, 24 Jun 2016 01:45:15 -0400 Date: Fri, 24 Jun 2016 15:45:35 +1000 From: David Gibson Message-ID: <20160624054535.GK15625@voom.fritz.box> References: <1466704050-15108-1-git-send-email-nikunj@linux.vnet.ibm.com> <1466704050-15108-5-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LHvWgpbS7VDUdu2f" Content-Disposition: inline In-Reply-To: <1466704050-15108-5-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1 04/11] ppc/xics: Remove unused xics_set_irq_type() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org, Benjamin Herrenschmidt --LHvWgpbS7VDUdu2f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2016 at 11:17:23PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt >=20 > Signed-off-by: Benjamin Herrenschmidt > Reviewed-by: David Gibson > Signed-off-by: Nikunj A Dadhania This stands on its own so I've applied it to ppc-for-2.7 (adjusting for context conflicts, obviously). > --- > hw/intc/xics.c | 11 ----------- > include/hw/ppc/xics.h | 1 - > 2 files changed, 12 deletions(-) >=20 > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > index 40969ee..4f15a2d 100644 > --- a/hw/intc/xics.c > +++ b/hw/intc/xics.c > @@ -695,17 +695,6 @@ void ics_set_irq_type(ICSState *ics, int srcno, bool= lsi) > lsi ? XICS_FLAGS_IRQ_LSI : XICS_FLAGS_IRQ_MSI; > } > =20 > -void xics_set_irq_type(XICSState *icp, int irq, bool lsi) > -{ > - int src =3D xics_find_source(icp, irq); > - ICSState *ics; > - > - assert(src >=3D 0); > - > - ics =3D &icp->ics[src]; > - ics_set_irq_type(ics, irq - ics->offset, lsi); > -} > - > static void xics_register_types(void) > { > type_register_static(&xics_common_info); > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h > index 32ea706..2a9b91d 100644 > --- a/include/hw/ppc/xics.h > +++ b/include/hw/ppc/xics.h > @@ -170,7 +170,6 @@ struct ICSIRQState { > #define XICS_IRQS_SPAPR 1024 > =20 > qemu_irq xics_get_qirq(XICSState *icp, int irq); > -void xics_set_irq_type(XICSState *icp, int irq, bool lsi); > int xics_spapr_alloc(XICSState *icp, int src, int irq_hint, bool lsi, > Error **errp); > int xics_spapr_alloc_block(XICSState *icp, int src, int num, bool lsi, --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --LHvWgpbS7VDUdu2f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXbMj/AAoJEGw4ysog2bOS7UoQAOVwLE3JMEz9KVpX5aM+tdU8 rtEAgzCRBaNawfeKsoAHUfZFgDKHRiSweWcuqRSWXQmOpuI7NMe4KEhSlUHxJyqz LUX6WJVYxINrFf6Avfmwz/jH0a1If+LDppVJmY7IAKbcxJZM7BlPJSJMGz6C1F0i 7mXVkwietX0kCVxzlxOFPiQUvuu1qZESfDJ36XGpyeRO26tn81F1PaoAftfgiO+1 0NTiLS6Q1gDMO0vu9BHMout+PmEkDul0Bx80MQ77539IxzW1q4ncHrVx0sNcENdW iPxVWglHMPMabsVtEzUXM5rZHcR8vjilxskgHAbWF0YCax7TyQzjcEq0d3xFetET ogfxyTkXAugrSnKfKIuE/z0fAg7xzkqRMK66EMmXOOhvCIkJot0wmKSk2h3eaOO+ AojkGZxTCRaMIhnFEEd8vqYbkY8UZmOiP35b7qvcPwLcdezCOmbd3T+YMmQUrv/a MtsbeIMwOh5ofb2wXdEjcg4rISqc7GzIHCJu98iHsiS4l3wVGRBVoCOfLDXK01y4 ueRElqzWdB4b7/Yd0XcgWHCms1B5Uqe2mPo2wF9jsBzTZuq/5v7rFe+6Fq55Fb/N vNXPTEfNuP/G/LVVfnCtGq2sfl+gxaVwVzjIrH9m/mvLKAsguXq85mQk3eXXUaA8 h6F5uu2AnCvKSW8hj0vM =UEPq -----END PGP SIGNATURE----- --LHvWgpbS7VDUdu2f--