From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGLDM-00046i-8r for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:07:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGLDI-0007Kx-BE for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:07:44 -0400 Date: Fri, 24 Jun 2016 15:07:26 +0800 From: Fam Zheng Message-ID: <20160624070726.GF13266@ad.usersys.redhat.com> References: <1466721446-27737-1-git-send-email-eblake@redhat.com> <1466721446-27737-21-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466721446-27737-21-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment into BlockLimit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, stefanha@redhat.com, Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven On Thu, 06/23 16:37, Eric Blake wrote: > It makes more sense to have ALL block size limit constraints > in the same struct. Improve the documentation while at it. > > Simplify a couple of conditionals, now that we have audited and > documented that request_alignment is always non-zero. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng