From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGLFJ-0006If-9h for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGLFI-0008FA-95 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:09:45 -0400 Date: Fri, 24 Jun 2016 15:09:29 +0800 From: Fam Zheng Message-ID: <20160624070929.GG13266@ad.usersys.redhat.com> References: <1466721446-27737-1-git-send-email-eblake@redhat.com> <1466721446-27737-22-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466721446-27737-22-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 21/22] block: Fix error message style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, stefanha@redhat.com, Max Reitz On Thu, 06/23 16:37, Eric Blake wrote: > error_setg() is not supposed to be used for multi-sentence > messages; tweak the message to append a hint instead. > > Signed-off-by: Eric Blake > > --- > v3: new patch > --- > block/raw-posix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index d3d7cce..c979ac3 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -350,8 +350,8 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp) > } > > if (!s->buf_align || !bs->bl.request_alignment) { > - error_setg(errp, "Could not find working O_DIRECT alignment. " > - "Try cache.direct=off."); > + error_setg(errp, "Could not find working O_DIRECT alignment"); > + error_append_hint(errp, "Try cache.direct=off\n"); > } > } > > -- > 2.5.5 > Reviewed-by: Fam Zheng