From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGLUR-0001kA-04 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:25:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGLUQ-0005LC-0y for qemu-devel@nongnu.org; Fri, 24 Jun 2016 03:25:22 -0400 Date: Fri, 24 Jun 2016 15:25:09 +0800 From: Fam Zheng Message-ID: <20160624072509.GI13266@ad.usersys.redhat.com> References: <20160624051227.8417-1-famz@redhat.com> <20160624051227.8417-3-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/4] virtio: Always use aio path to set host handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Kevin Wolf , Max Reitz , Stefan Hajnoczi , qemu-block@nongnu.org, "Michael S. Tsirkin" On Fri, 06/24 08:39, Paolo Bonzini wrote: > > > On 24/06/2016 07:12, Fam Zheng wrote: > > Apart from the interface difference, the aio version works the same as > > the non-aio one. The event notifier versus aio fd handler makes no > > diffeerence, except the former led to an ugly patch in commit > > ab27c3b5e7, which won't be necessary any more. > > > > As the first step to unify them, all callers are switched to this > > renamed aio iterface, and function comment is added. > > I think this is too aggressive, and I'm not sure it's correct. > bdrv_drain wants to look at block devices only, while this would also > process NICs too for example. I don't know the effect. > > Can we do this only for virtio-blk and virtio-scsi? OK, I'll see. :) Fam