From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNRH-0002BJ-IZ for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:30:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGNRC-0006JK-Kf for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:30:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNRC-0006J5-Ft for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:30:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0730E3B730 for ; Fri, 24 Jun 2016 09:30:10 +0000 (UTC) Date: Fri, 24 Jun 2016 10:30:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160624093006.GB2250@work-vm> References: <1466702539-17607-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466702539-17607-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/6] serial: flow control fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org * Paolo Bonzini (pbonzini@redhat.com) wrote: > v1->v2: > - use guint for GSource tags > - move migration patch last because it set watch_tag but never read it > - add more details in errors > - don't drop tsr_retry sanity check in migration patch Thanks, Reviewed-by: Dr. David Alan Gilbert Note you have a 1 character typo in both of your errors, + "(tsr empty, tsr_retry=%d", s->tsr_retry); + "(tsr not empty, tsr_retry=0"); I think you want to add the close brackets, i.e.: + "(tsr empty, tsr_retry=%d)", s->tsr_retry); + "(tsr not empty, tsr_retry=0)"); Dave > > Paolo Bonzini (6): > serial: make tsr_retry unsigned > serial: simplify tsr_retry reset > serial: separate serial_xmit and serial_watch_cb > char: change qemu_chr_fe_add_watch to return unsigned > serial: remove watch on reset > serial: reinstate watch after migration > > hw/char/cadence_uart.c | 9 ++++--- > hw/char/serial.c | 67 ++++++++++++++++++++++++++++++++++++------------ > include/hw/char/serial.h | 3 ++- > include/sysemu/char.h | 16 ++++++++++-- > net/vhost-user.c | 2 +- > qemu-char.c | 8 +++--- > 6 files changed, 78 insertions(+), 27 deletions(-) > > -- > 2.5.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK