From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bGRQn-0004hZ-Tv
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 09:46:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bGRQl-00058p-VR
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 09:46:00 -0400
Date: Fri, 24 Jun 2016 15:45:48 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160624134548.GC5422@noname.redhat.com>
References: <1466721446-27737-1-git-send-email-eblake@redhat.com>
	<1466721446-27737-21-git-send-email-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466721446-27737-21-git-send-email-eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment
 into BlockLimit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, famz@redhat.com, stefanha@redhat.com, Max Reitz <mreitz@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>

Am 24.06.2016 um 00:37 hat Eric Blake geschrieben:
> It makes more sense to have ALL block size limit constraints
> in the same struct.  Improve the documentation while at it.
> 
> Simplify a couple of conditionals, now that we have audited and
> documented that request_alignment is always non-zero.

Now you mention in the commit message that request_alignment is always
non-zero and this is supposedly documented...

> Signed-off-by: Eric Blake <eblake@redhat.com>
> 

> @@ -324,6 +324,12 @@ struct BlockDriver {
>  };
> 
>  typedef struct BlockLimits {
> +    /* Alignment requirement, in bytes, for offset/length of I/O
> +     * requests. Must be a power of 2 less than INT_MAX. A value of 0
> +     * defaults to 1 for drivers with modern byte interfaces, and to
> +     * 512 otherwise. */
> +    uint32_t request_alignment;

...but you didn't actually change the documentation.

This is the only problem I saw in this series, so if you post a new
version of the comment, I can change it while applying the series.

Kevin