From: Andrew Jones <drjones@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits
Date: Fri, 24 Jun 2016 19:22:23 +0200 [thread overview]
Message-ID: <20160624172223.gxbd7nsna6spflxt@hawk.localdomain> (raw)
In-Reply-To: <CAFEAcA8xQV3PJ7BgFa=ohYDGqyVEtQ9bssoB+0JkGaGJqtaK=w@mail.gmail.com>
On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote:
> On 24 June 2016 at 17:15, Andrew Jones <drjones@redhat.com> wrote:
> > On Fri, Jun 24, 2016 at 06:03:21PM +0200, Andrew Jones wrote:
> >> So we can either
> >> a) play it safe and always use clusters of 4 for ARM guests, and
> >> KVM will get "fixed" when we start managing the guest's MPIDR
> >> from userspace, or
> >> b) use 8 here, as TCG always has, and KVM does for AArch32 guests.
> >> This might be less safe, but also improves SGI efficiency.
> >
> > Actually AArch32 guests would even use all 16 tlist bits on gicv3, if
> > there was a KVM host available to try it. So the (b) option shouldn't
> > be "use 8" it should be "don't treat 32-bit guests differently"
>
> KVM AArch32 is 4 CPUs per cluster:
> http://lxr.free-electrons.com/source/arch/arm/kvm/coproc.c#L109
Hmm... yes, it should use coproc.c, but here's what I get when I
test
qemu-system-aarch64 \
-machine virt,gic-version=2,accel=kvm \
-cpu host,aarch64=off \
-device virtio-serial-device \
-device virtconsole,chardev=ctd \
-chardev testdev,id=ctd \
-display none -serial stdio \
-kernel arm/selftest.flat \
-append smp -smp 8
PSCI version 0.2
PASS: selftest: smp: PSCI version
PASS: selftest: smp: CPU( 1) mpidr=80000001
PASS: selftest: smp: CPU( 2) mpidr=80000002
PASS: selftest: smp: CPU( 3) mpidr=80000003
PASS: selftest: smp: CPU( 4) mpidr=80000004
PASS: selftest: smp: CPU( 5) mpidr=80000005
PASS: selftest: smp: CPU( 6) mpidr=80000006
PASS: selftest: smp: CPU( 7) mpidr=80000007
PASS: selftest: smp: CPU( 0) mpidr=80000000
SUMMARY: 9 tests
(arm/selftest.flat built from
https://github.com/rhdrjones/kvm-unit-tests/tree/arm/gic)
Other configurations give the expected mpidrs. I'll look into
it more next week.
Thanks,
drew
next prev parent reply other threads:[~2016-06-24 17:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 18:58 [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits Andrew Jones
2016-06-23 11:15 ` Peter Maydell
2016-06-23 11:50 ` Andrew Jones
2016-06-24 16:03 ` Andrew Jones
2016-06-24 16:15 ` Andrew Jones
2016-06-24 16:41 ` Peter Maydell
2016-06-24 17:22 ` Andrew Jones [this message]
2016-06-24 17:27 ` Peter Maydell
2016-06-27 6:41 ` Andrew Jones
2016-06-27 7:51 ` Marc Zyngier
2016-06-27 8:32 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624172223.gxbd7nsna6spflxt@hawk.localdomain \
--to=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).