From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bGZFv-0000BG-Ez
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 18:07:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bGZFr-0003uR-69
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 18:07:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bGZFr-0003u9-0b
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 18:07:15 -0400
Date: Sat, 25 Jun 2016 01:07:10 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160624220710.GA8254@redhat.com>
References: <1466105332-10285-1-git-send-email-marcandre.lureau@redhat.com>
	<1466105332-10285-4-git-send-email-marcandre.lureau@redhat.com>
	<20160623073840-mutt-send-email-mst@redhat.com>
	<20160623074849-mutt-send-email-mst@redhat.com>
	<934708551.1342481.1466672883154.JavaMail.zimbra@redhat.com>
	<20160623194541-mutt-send-email-mst@redhat.com>
	<CAJ+F1CLu9LidBh3x-wWdtoqWt5gaaiw3McJQMGCbfTbYJwYMaQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1CLu9LidBh3x-wWdtoqWt5gaaiw3McJQMGCbfTbYJwYMaQ@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, QEMU <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-Andr=E9 Lureau wrote:
> On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin <mst@redhat.com> wr=
ote:
> >> > Maybe what you want is a need_unlink feature.
> >> > Set it for unix sockets only, that would make some sense.
> >>
> >> Oh perhaps what you mean is that if the fd was passed, we should cle=
anup the unix socket? Yes, I think we should do that then. I'll update th=
e series.
>=20
> Actually it's not possible to pass a listening fd to a socket chardev
> today (the path argument doesn't understand /dev/fdset), so only path
> created by qemu will be cleaned up.
>=20
> >
> > I'd like it better contained - that's all. So let's set a flag that s=
ays
> > "must unlink" as opposed to "it's listening".
>=20
> You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to
> QIO_CHANNEL_FEATURE_LISTEN_MUST_UNLINK ?

QIO_CHANNEL_FEATURE_UNLINK_ON_CLOSE

or something like this.

Or maybe QIO_CHANNEL_FEATURE_BOUND

> Or to add another feature
> flag? I don't think that brings anything useful here.

The point is that in the future we might be listening on sockets where
we did not bind it.  I would think that in that case, we do not want to
unlink it. So name should reflect this somehow.

> What would you think Daniel?
>=20
> --=20
> Marc-Andr=E9 Lureau