From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHNRN-0007yX-3n for qemu-devel@nongnu.org; Sun, 26 Jun 2016 23:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHNRJ-0007Sl-G4 for qemu-devel@nongnu.org; Sun, 26 Jun 2016 23:42:28 -0400 Date: Mon, 27 Jun 2016 13:43:42 +1000 From: David Gibson Message-ID: <20160627034342.GE4242@voom.fritz.box> References: <1466704050-15108-1-git-send-email-nikunj@linux.vnet.ibm.com> <1466704050-15108-6-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hwvH6HDNit2nSK4j" Content-Disposition: inline In-Reply-To: <1466704050-15108-6-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1 05/11] ppc/xics: Replace "icp" with "xics" in most places List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org, Benjamin Herrenschmidt --hwvH6HDNit2nSK4j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2016 at 11:17:24PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt >=20 > The "ICP" is a different object than the "XICS". For historical reasons, > we have a number of places where we name a variable "icp" while it contai= ns > a XICSState pointer. There *is* an ICPState structure too so this makes > the code really confusing. >=20 > This is a mechanical replacement of all those instances to use the name > "xics" instead. There should be no functional change. >=20 > Signed-off-by: Benjamin Herrenschmidt > [spapr_cpu_init has been moved to spapr_cpu_core.c, change there] > Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hwvH6HDNit2nSK4j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXcKDuAAoJEGw4ysog2bOSUMAQAJrquQHQrbYCGQm0wiyhHW5S MyRXBrg9Nl76CXLwDGUSU3zJ39fS/5NXXNY+i/mvDSUzC84eM5alLWeGTTFTQfDg SNuomIRHdBKmE03Dk9/HDxYhBPhaqicTFnMDbEirsx4F5E4tedpkuNG2iv6Vis/B T0NIQkhrst/2yuIgnd2IO8LwSUsje7x+MZYE5T/vi44bmahOy46QgBxbN6JjwqrL kSpt8NymXgB5ujVMtqgwzuffJIOohH/mwWXpFRxKeII9M+zTNRawZxGJ2CVHmN8z QiYu2yD5PsmFd2ZsfbwyfFdUEp14MD/jiC6V7l8kCYHyDtA6oTwgXqr0Lc9JhGV5 BkGqrsWwi0f6wAOCz2/Wp2kKEuxKvz0X8cYOkmprc2xYy2hKc6YnVLCuVWb0LWg/ HR+Je+T3T5zQs/7xCloYhqAwmL4LuIOTgCnLPm2yN355Nct0sWe4tJbieasFv2/3 PtRttqU50BRv/JLgHzMrQhmt7nA6ZD9RZiFwoQOmP8rxHLZEvsmUKoGF8PYSRx88 0Z9c4MfwC9isRPmJ6bIGSQYAqHBVkcuI669nDIrcFgg85jAu5d4uJiQSSQhY/g2k qiQmSPQc5gu0QNvRPJBz4YxBIptZ3AvG8v2MkQPQHIpeEvl49IJuz/FMwU2Pp/uv xrICDkVbwjiqXnhCD/lO =6UkL -----END PGP SIGNATURE----- --hwvH6HDNit2nSK4j--