From: David Gibson <david@gibson.dropbear.id.au>
To: alarson@ddci.com
Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb
Date: Mon, 27 Jun 2016 15:32:13 +1000 [thread overview]
Message-ID: <20160627053212.GN4242@voom.fritz.box> (raw)
In-Reply-To: <OFA3E0BD1F.6E2689D1-ON86257FDF.000E50D8-86257FDF.000E78A2@ddci.com>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
On Sun, Jun 26, 2016 at 09:38:03PM -0500, alarson@ddci.com wrote:
> David Gibson <david@gibson.dropbear.id.au> wrote on 06/26/2016 08:36:52
> PM:
>
> > From: David Gibson <david@gibson.dropbear.id.au>
> > To: Aaron Larson <alarson@ddci.com>
> > Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
> > Date: 06/26/2016 08:58 PM
> > Subject: Re: [PATCH] target-ppc: Eliminate redundant and incorrect
> function booke206_page_size_to_tlb
> >
> > On Fri, Jun 24, 2016 at 12:11:00PM -0700, Aaron Larson wrote:
> > >
> > > Eliminate redundant and incorrect booke206_page_size_to_tlb function
> > > from ppce500_spin.c in preference to previously existing but newly
> > > exported definition from e500.c
> > >
> > > Signed-off-by: Aaron Larson <alarson@ddci.com>
> >
> > Uh.. sorry.. can you provide a reference explaining why the removed
> > version is wrong? Doesn't this depend on which MMU Architecture
> > Version we're emulating?
>
> Sure, the code is internally inconsistent (shift assumed didn't match
> shift defined). I will provide an update commit message, similar to the
> original posting I made a few days ago with the "direction"
> corrected.
Right, I can see that the two old versions were different, which was
clearly wrong. What I'm looking for is an explanation of why the one
you've picked is the right one, not the other one.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-27 5:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 19:11 [Qemu-devel] [PATCH] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb Aaron Larson
2016-06-27 1:36 ` David Gibson
2016-06-27 2:38 ` alarson
2016-06-27 5:32 ` David Gibson [this message]
2016-06-27 15:55 ` alarson
2016-06-28 3:16 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627053212.GN4242@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=alarson@ddci.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).