From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHP7x-0006Xf-KF for qemu-devel@nongnu.org; Mon, 27 Jun 2016 01:30:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHP7v-0000Q9-Di for qemu-devel@nongnu.org; Mon, 27 Jun 2016 01:30:32 -0400 Date: Mon, 27 Jun 2016 15:32:13 +1000 From: David Gibson Message-ID: <20160627053212.GN4242@voom.fritz.box> References: <201606241911.u5OJB05n006837@linux03a.ddci.com> <20160627013652.GC4242@voom.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vDEbda84Uy/oId5W" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alarson@ddci.com Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org --vDEbda84Uy/oId5W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 26, 2016 at 09:38:03PM -0500, alarson@ddci.com wrote: > David Gibson wrote on 06/26/2016 08:36:52= =20 > PM: >=20 > > From: David Gibson > > To: Aaron Larson > > Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org > > Date: 06/26/2016 08:58 PM > > Subject: Re: [PATCH] target-ppc: Eliminate redundant and incorrect=20 > function booke206_page_size_to_tlb > >=20 > > On Fri, Jun 24, 2016 at 12:11:00PM -0700, Aaron Larson wrote: > > >=20 > > > Eliminate redundant and incorrect booke206_page_size_to_tlb function > > > from ppce500_spin.c in preference to previously existing but newly > > > exported definition from e500.c > > >=20 > > > Signed-off-by: Aaron Larson > >=20 > > Uh.. sorry.. can you provide a reference explaining why the removed > > version is wrong? Doesn't this depend on which MMU Architecture > > Version we're emulating? >=20 > Sure, the code is internally inconsistent (shift assumed didn't match=20 > shift defined). I will provide an update commit message, similar to the= =20 > original posting I made a few days ago with the "direction" > corrected. Right, I can see that the two old versions were different, which was clearly wrong. What I'm looking for is an explanation of why the one you've picked is the right one, not the other one. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vDEbda84Uy/oId5W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXcLpcAAoJEGw4ysog2bOS34QQALMWUyFNjdoWalF4TCULSSL9 xr+BRqgDZDpqFjVEo32lLx99r+xplE0VHf22JlIa68vRZ5vHSsVoJpXfwGseyAVw gyVaGQWZgGgdWam0qwPMoyzZes1x/FpzbtzyWKHlMXx8y/ACCs2WrbOlwoio5uRF H8F0akhgYzsg+3JUJH1fHX7/1qZOEWxfiC66BdXlQQJxr9ZcVaALI0pXkCRMYkuK lt5oI8Ly9nAikPRbb6GSLmbOtmfaBnwNkq0pd0cKqeT3GbORTHHCzV35Kns/GkJw WEMQmfBB7FctuSpo9e324mfVIIOt7qCNNzOvnCuTOfWNwkLvtUOH7LoogE0KTib4 m8RCa3nqgBdVgUgDXoMO60RQ5n0R58gvFSx0eWWmQK4v4jbvy7WlC1kAK6+2eaQI +vTshoUCf0VrEJlXbB/eJ/kxJQm6r4APdoICLebb+cVIM3GmksxQ0DMVeFzJnNhk vps+lLbJv5Isg/7VG1hIW0Z6e7iBHwC3fNtrUdEdfFbvtJh/RiPJxjmEdXPorWoL h9BabK+xfZ950akLn6Z+6KEaRoAqCg+6SzoKb8SYCA9masPTsZ7mXYeX6vBH/lSR xMsntYiSNiyHZbPvZQakhqddZ9oESqImXz8dFwbK3bjYWTXP51U+VBd5cqjl2pb+ RZAb8kU2vQkyyovjNXCK =Cnb6 -----END PGP SIGNATURE----- --vDEbda84Uy/oId5W--