From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHQNh-0002W7-2B for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHQNc-00046n-2A for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:50:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHQNb-00046i-Sb for qemu-devel@nongnu.org; Mon, 27 Jun 2016 02:50:47 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F4ADC0467C9 for ; Mon, 27 Jun 2016 06:50:47 +0000 (UTC) Date: Mon, 27 Jun 2016 12:20:44 +0530 From: Amit Shah Message-ID: <20160627065044.GC1389@grmbl.mre> References: <1466536447-30146-1-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466536447-30146-1-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, mst@redhat.com, quintela@redhat.com, kraxel@redhat.com, Paolo Bonzini On (Tue) 21 Jun 2016 [20:13:54], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This series converts the outer most layer of virtio to > use VMState macros; this is the easy bit, but I'm hoping that > having done that, the next trick is to nibble away at the virtio_save/load > functions and all of the zillions of device/bus helpers. I'm not sure how to go about this though - should we pick these patches now, and keep taking smaller stabs at the problem; vs maintaining a separate tree and see how the series grows and what directions it takes. > I think the first two patches are the most controversial; > they remove migration support for old version of virtio-net and virtio-serial; > (for virtio-net versions prior to 0.11 and for virtio-serial prior to 0.13). > I'm working on the basis that migration has bit rotted enough so > that the streams aren't migration compatible for that long back > on upstream - but if anyone knows otherwise please shout. I think it's fine to remove these. Distributions that depend on older releases should take the burden of maintaining the older state. However, as you say, it could be controversial, so let's wait for more input from others. Amit