From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHRcu-0007Mo-LV for qemu-devel@nongnu.org; Mon, 27 Jun 2016 04:10:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHRcq-000489-91 for qemu-devel@nongnu.org; Mon, 27 Jun 2016 04:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHRcp-00047W-UL for qemu-devel@nongnu.org; Mon, 27 Jun 2016 04:10:36 -0400 Date: Mon, 27 Jun 2016 09:10:30 +0100 From: "Daniel P. Berrange" Message-ID: <20160627081030.GC12067@redhat.com> Reply-To: "Daniel P. Berrange" References: <1466105332-10285-1-git-send-email-marcandre.lureau@redhat.com> <1466105332-10285-4-git-send-email-marcandre.lureau@redhat.com> <20160623073840-mutt-send-email-mst@redhat.com> <20160623074849-mutt-send-email-mst@redhat.com> <934708551.1342481.1466672883154.JavaMail.zimbra@redhat.com> <20160623194541-mutt-send-email-mst@redhat.com> <20160624220710.GA8254@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160624220710.GA8254@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU , Paolo Bonzini On Sat, Jun 25, 2016 at 01:07:10AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-Andr=C3=A9 Lureau wrote: > > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin = wrote: > > >> > Maybe what you want is a need_unlink feature. > > >> > Set it for unix sockets only, that would make some sense. > > >> > > >> Oh perhaps what you mean is that if the fd was passed, we should c= leanup the unix socket? Yes, I think we should do that then. I'll update = the series. > >=20 > > Actually it's not possible to pass a listening fd to a socket chardev > > today (the path argument doesn't understand /dev/fdset), so only path > > created by qemu will be cleaned up. > >=20 > > > > > > I'd like it better contained - that's all. So let's set a flag that= says > > > "must unlink" as opposed to "it's listening". > >=20 > > You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to > > QIO_CHANNEL_FEATURE_LISTEN_MUST_UNLINK ? >=20 > QIO_CHANNEL_FEATURE_UNLINK_ON_CLOSE >=20 > or something like this. >=20 > Or maybe QIO_CHANNEL_FEATURE_BOUND >=20 > > Or to add another feature > > flag? I don't think that brings anything useful here. >=20 > The point is that in the future we might be listening on sockets where > we did not bind it. I would think that in that case, we do not want to > unlink it. So name should reflect this somehow. There is no possibility of listening on sockets without binding to them with the current design of the code. If & when we want such support we can adapt as needed, but I don't see any real point in trying to support something that is impossible right now. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|