From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bHeG9-0006su-Vy
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:40:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bHeG4-0002tp-Ra
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:40:00 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bHeG2-0002tJ-IY
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 17:39:56 -0400
Date: Mon, 27 Jun 2016 17:39:45 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20160627213944.GC15173@flamenco>
References: <1467054136-10430-1-git-send-email-cota@braap.org>
	<1467054136-10430-12-git-send-email-cota@braap.org>
	<db3490d5-34e4-9f49-8174-fd8d7d521d8c@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <db3490d5-34e4-9f49-8174-fd8d7d521d8c@twiddle.net>
Subject: Re: [Qemu-devel] [RFC 11/30] target-i386: add atomic helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@greensocs.com>, Peter Maydell <peter.maydell@linaro.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Sergey Fedorov <serge.fdrv@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>

On Mon, Jun 27, 2016 at 13:27:35 -0700, Richard Henderson wrote:
> On 06/27/2016 12:01 PM, Emilio G. Cota wrote:
> >This patch only adds the helpers. Functions to invoke the helpers
> >from translated code are generated in subsequent patches.
> >
> >Signed-off-by: Emilio G. Cota <cota@braap.org>
> >---
> > target-i386/helper.h     | 34 ++++++++++++++++++++++++++++++++++
> > target-i386/mem_helper.c | 38 ++++++++++++++++++++++++++++++++++++++
> > target-i386/translate.c  | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 117 insertions(+)
> 
> 
> These are bare wrappers around what you've just added to exec/cpu_ldst*.
> 
> (1) Is there any reason these shouldn't go into tcg-runtime.h and
> tcg-runtime.c instead?
> 
> (2) If so, is there any good reason to add these to cpu_ldst* instead of
> *only* adding them as helpers to tcg-runtime.c?

The only reason is my incompetence :-) I didn't know about tcg-runtime.

Thanks,

		Emilio