From: David Gibson <david@gibson.dropbear.id.au>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com,
mst@redhat.com, davidkiarie4@gmail.com, peterx@redhat.com,
bd.aviv@gmail.com, jan.kiszka@web.de, agraf@suse.de,
qemu-ppc@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V5 1/5] hw/ppc: realize the PCI root bus as part of mac99 init
Date: Tue, 28 Jun 2016 12:56:06 +1000 [thread overview]
Message-ID: <20160628025606.GT4242@voom.fritz.box> (raw)
In-Reply-To: <1467041915-19784-2-git-send-email-marcel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Mon, Jun 27, 2016 at 06:38:31PM +0300, Marcel Apfelbaum wrote:
> Mac99's PCI root bus is not part of a host bridge,
> realize it manually.
Um.. how did this ever work?
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> hw/ppc/mac_newworld.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> index 32e88b3..7d25106 100644
> --- a/hw/ppc/mac_newworld.c
> +++ b/hw/ppc/mac_newworld.c
> @@ -380,6 +380,7 @@ static void ppc_core99_init(MachineState *machine)
> pci_bus = pci_pmac_init(pic, get_system_memory(), get_system_io());
> machine_arch = ARCH_MAC99;
> }
> + object_property_set_bool(OBJECT(pci_bus), true, "realized", &error_abort);
>
> machine->usb |= defaults_enabled() && !machine->usb_disabled;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-28 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 15:38 [Qemu-devel] [PATCH V5 0/5] enable iommu with -device Marcel Apfelbaum
2016-06-27 15:38 ` [Qemu-devel] [PATCH V5 1/5] hw/ppc: realize the PCI root bus as part of mac99 init Marcel Apfelbaum
2016-06-28 2:56 ` David Gibson [this message]
2016-06-28 8:00 ` Marcel Apfelbaum
2016-06-29 1:42 ` David Gibson
2016-06-27 15:38 ` [Qemu-devel] [PATCH V5 2/5] hw/pci: delay bus_master_enable_region initialization Marcel Apfelbaum
2016-06-27 15:38 ` [Qemu-devel] [PATCH V5 3/5] q35: allow dynamic sysbus Marcel Apfelbaum
2016-06-27 15:38 ` [Qemu-devel] [PATCH V5 4/5] hw/iommu: enable iommu with -device Marcel Apfelbaum
2016-06-27 15:38 ` [Qemu-devel] [PATCH V5 5/5] machine: remove iommu property Marcel Apfelbaum
2016-06-28 2:57 ` David Gibson
2016-06-28 8:07 ` Marcel Apfelbaum
2016-06-29 1:43 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628025606.GT4242@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).