From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
stefanha@redhat.com, mst@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label
Date: Tue, 28 Jun 2016 10:04:01 +0100 [thread overview]
Message-ID: <20160628090401.GA2798@stefanha-x1.localdomain> (raw)
In-Reply-To: <63c25f3e-87e1-9c88-76cb-1775bd8c5db3@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Tue, Jun 28, 2016 at 09:48:10AM +0200, Paolo Bonzini wrote:
>
>
> On 20/05/2016 10:20, Xiao Guangrong wrote:
> > + if (size <= nvdimm->label_size) {
> > + HostMemoryBackend *hostmem = dimm->hostmem;
> > + char *path = object_get_canonical_path_component(OBJECT(hostmem));
> > +
> > + error_setg(errp, "the size of memdev %s (0x%" PRIx64 ") is too"
> > + "small to contain nvdimm label (0x%" PRIx64 ")",
> > + path, memory_region_size(mr), nvdimm->label_size);
>
> Coverity reports here that path is leaked.
I will send a patch.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-28 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:19 [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong
2016-05-20 8:19 ` [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region() Xiao Guangrong
2016-05-30 18:36 ` Stefan Hajnoczi
2016-05-20 8:19 ` [Qemu-devel] [PATCH v2 02/15] pc-dimm: introduce realize callback Xiao Guangrong
2016-05-30 18:37 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong
2016-05-30 18:42 ` Stefan Hajnoczi
2016-05-31 2:04 ` Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label Xiao Guangrong
2016-05-30 18:46 ` Stefan Hajnoczi
2016-06-28 7:48 ` Paolo Bonzini
2016-06-28 9:04 ` Stefan Hajnoczi [this message]
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 05/15] acpi: add aml_object_type Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 06/15] acpi: add aml_call5 Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 08/15] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 09/15] nvdimm acpi: check UUID Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 10/15] nvdimm acpi: abstract the operations for root & nvdimm devices Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 11/15] nvdimm acpi: check revision Xiao Guangrong
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2016-05-30 18:49 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2016-05-30 18:51 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 14/15] nvdimm acpi: support Set " Xiao Guangrong
2016-05-30 18:51 ` Stefan Hajnoczi
2016-05-20 8:20 ` [Qemu-devel] [PATCH v2 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong
2016-05-30 18:52 ` [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi
2016-05-31 2:09 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628090401.GA2798@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).