From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHox0-0001Ci-JQ for qemu-devel@nongnu.org; Tue, 28 Jun 2016 05:05:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHowx-00049Q-De for qemu-devel@nongnu.org; Tue, 28 Jun 2016 05:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHowx-00049K-7x for qemu-devel@nongnu.org; Tue, 28 Jun 2016 05:04:55 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 64DB880500 for ; Tue, 28 Jun 2016 09:04:54 +0000 (UTC) Date: Tue, 28 Jun 2016 14:34:50 +0530 From: Amit Shah Message-ID: <20160628090450.GE1389@grmbl.mre> References: <1466536447-30146-1-git-send-email-dgilbert@redhat.com> <20160627065044.GC1389@grmbl.mre> <20160627075346.GA2249@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160627075346.GA2249@work-vm> Subject: Re: [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, mst@redhat.com, quintela@redhat.com, kraxel@redhat.com, Paolo Bonzini On (Mon) 27 Jun 2016 [08:53:47], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.shah@redhat.com) wrote: > > On (Tue) 21 Jun 2016 [20:13:54], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > This series converts the outer most layer of virtio to > > > use VMState macros; this is the easy bit, but I'm hoping that > > > having done that, the next trick is to nibble away at the virtio_save/load > > > functions and all of the zillions of device/bus helpers. > > > > I'm not sure how to go about this though - should we pick these > > patches now, and keep taking smaller stabs at the problem; vs > > maintaining a separate tree and see how the series grows and what > > directions it takes. > > My intention was that this set would be taken as is and then we'd do some > more later. Killing off register_savevm will probably take another > couple of dozen patches all over the place. Turning all of virtio > into VMState will probably take a lot more. OK - I don't think this set should be controversial, but I'll wait this week to see if there are any comments; will send a pull req next week if nothing pops up. Thanks, Amit