From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio: Tell the user what went wrong when event_notifier_init failed
Date: Tue, 28 Jun 2016 09:44:57 +0200 [thread overview]
Message-ID: <20160628094457.263a2043.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1467065523-13881-1-git-send-email-thuth@redhat.com>
On Tue, 28 Jun 2016 00:12:03 +0200
Thomas Huth <thuth@redhat.com> wrote:
> event_notifier_init() can fail in real life, for example when there
> are not enough open file handles available (EMFILE) when using a lot
> of devices. So instead of leaving the average user with a cryptic
> error number only, print out a proper error message with strerror()
> instead, so that the user has a better way to figure out what is
> going on and that using "ulimit -n" might help here for example.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/virtio/virtio-bus.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2016-06-28 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 22:12 [Qemu-devel] [PATCH] virtio: Tell the user what went wrong when event_notifier_init failed Thomas Huth
2016-06-27 22:38 ` Eric Blake
2016-06-28 7:44 ` Cornelia Huck [this message]
2016-07-14 12:41 ` Thomas Huth
2016-09-02 22:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628094457.263a2043.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).