From: Igor Mammedov <imammedo@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, mst@redhat.com, armbru@redhat.com,
eduardo.otubo@profitbricks.com, pkrempa@redhat.com,
marcel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 05/18] target-i386: cpu: replace custom apic-id setter/getter with static property
Date: Tue, 28 Jun 2016 09:45:48 +0200 [thread overview]
Message-ID: <20160628094548.2f80a89e@nial.brq.redhat.com> (raw)
In-Reply-To: <576D60C6.8040309@redhat.com>
On Fri, 24 Jun 2016 10:33:10 -0600
Eric Blake <eblake@redhat.com> wrote:
> On 06/24/2016 10:05 AM, Igor Mammedov wrote:
> > custom apic-id setter/getter doesn't do any property specific
> > checks anymorer, so clean it up and use more compact static
>
> s/anymorer/anymore/
Thanks,
I'll fix it on respin.
>
> > property DEFINE_PROP_UINT32 instead.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > target-i386/cpu.c | 45 ++++++---------------------------------------
> > 1 file changed, 6 insertions(+), 39 deletions(-)
> >
>
>
next prev parent reply other threads:[~2016-06-28 7:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 16:05 [Qemu-devel] [PATCH v2 00/18] pc: add CPU hot-add/hot-remove with device_add/device_del Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 01/18] target-i386: cpu: use uint32_t for X86CPU.apic_id Igor Mammedov
2016-07-04 14:09 ` Michael S. Tsirkin
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 02/18] pc: add x86_topo_ids_from_apicid() Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 03/18] pc: extract CPU lookup into a separate function Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 04/18] pc: cpu: consolidate apic-id validity checks in pc_cpu_pre_plug() Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 05/18] target-i386: cpu: replace custom apic-id setter/getter with static property Igor Mammedov
2016-06-24 16:33 ` Eric Blake
2016-06-28 7:45 ` Igor Mammedov [this message]
2016-07-04 14:10 ` Michael S. Tsirkin
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 06/18] target-i386: add socket/core/thread properties to X86CPU Igor Mammedov
2016-07-04 14:12 ` Michael S. Tsirkin
2016-07-04 16:40 ` Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 07/18] pc: set APIC ID based on socket/core/thread ids if it's not been set yet Igor Mammedov
2016-07-04 19:17 ` Eduardo Habkost
2016-07-05 5:31 ` Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 08/18] pc: implement query-hotpluggable-cpus callback Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 09/18] pc: delay setting number of boot CPUs to machine_done time Igor Mammedov
2016-07-04 14:17 ` Michael S. Tsirkin
2016-07-04 16:15 ` Igor Mammedov
2016-07-04 16:42 ` Michael S. Tsirkin
2016-07-05 5:29 ` Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 10/18] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug() Igor Mammedov
2016-06-24 16:05 ` [Qemu-devel] [PATCH v2 11/18] pc: cpu: allow device_add to be used with x86 cpu Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 12/18] apic: move MAX_APICS check to 'apic' class Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 13/18] apic: drop APICCommonState.idx and use APIC ID as index in local_apics[] Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 14/18] (kvm)apic: add unrealize callbacks Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 15/18] target-i386: do not ignore error and fix apic parent Igor Mammedov
2016-07-04 14:20 ` Michael S. Tsirkin
2016-07-04 16:39 ` Igor Mammedov
2016-07-05 7:30 ` Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 16/18] target-i386: fix apic object leak when CPU is deleted Igor Mammedov
2016-07-04 14:19 ` Michael S. Tsirkin
2016-07-04 15:25 ` Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 17/18] target-i386: add x86_cpu_unrealizefn() Igor Mammedov
2016-06-24 16:06 ` [Qemu-devel] [PATCH v2 18/18] pc: make device_del CPU work for x86 CPUs Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628094548.2f80a89e@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).