From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/7] virtio: Introduce virtio_add_queue_aio
Date: Tue, 28 Jun 2016 16:03:44 +0100 [thread overview]
Message-ID: <20160628150344.GO2798@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160624123934.10821-4-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Fri, Jun 24, 2016 at 08:39:30PM +0800, Fam Zheng wrote:
> +VirtQueue *virtio_add_queue_aio(VirtIODevice *vdev, int queue_size,
> + VirtIOHandleOutput handle_output)
> +{
> + return virtio_add_queue_internal(vdev, queue_size, handle_output, true);
> +}
> +
> +VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
> + VirtIOHandleOutput handle_output)
> +{
> + return virtio_add_queue_internal(vdev, queue_size, handle_output, false);
> +}
Please include doc comments for this new API explaining the meaning of
aio vs non-aio queues.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-28 15:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 12:39 [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths Fam Zheng
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 1/7] virtio-bus: Drop "set_handler" parameter Fam Zheng
2016-06-28 14:41 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 2/7] virtio: Add typedef for handle_output Fam Zheng
2016-06-28 14:54 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 3/7] virtio: Introduce virtio_add_queue_aio Fam Zheng
2016-06-28 15:03 ` Stefan Hajnoczi [this message]
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 4/7] virtio: Use aio_set_event_notifier for aio vq Fam Zheng
2016-06-28 15:09 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio Fam Zheng
2016-06-28 15:12 ` Stefan Hajnoczi
2016-06-28 15:30 ` Paolo Bonzini
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 6/7] virtio-scsi: " Fam Zheng
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 7/7] Revert "mirror: Workaround for unexpected iohandler events during completion" Fam Zheng
2016-06-28 15:18 ` [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628150344.GO2798@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).