From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths
Date: Tue, 28 Jun 2016 16:18:04 +0100 [thread overview]
Message-ID: <20160628151804.GR2798@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160624123934.10821-1-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Fri, Jun 24, 2016 at 08:39:27PM +0800, Fam Zheng wrote:
> v2: Only convert virtio-{blk,scsi}. [Paolo]
>
> This series is based on top of Cornelia's
>
> [PATCH 0/6] virtio: refactor host notifiers
>
> The benifit is we don't use event_notifier_set_handler even in non-dataplane
> now, which in turn makes virtio-blk and virtio-scsi follow block layer aio
> context semantics. Specifically, I/O requests must come from
> blk_get_aio_context(blk) events, rather than iohandler_get_aio_context(), so
> that bdrv_drained_begin/end will work as expected.
>
> Patch 4 reverts the hack (ab27c3b5e7) we added for 2.6. Lately, commit
> b880481579 added another pair of bdrv_drained_begin/end so the crash cannot
> happen even without ab27c3b5e7, but in order to avoid leaking requests, patch
> two is still a must.
Looks good overall. I have left comments.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-06-28 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 12:39 [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths Fam Zheng
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 1/7] virtio-bus: Drop "set_handler" parameter Fam Zheng
2016-06-28 14:41 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 2/7] virtio: Add typedef for handle_output Fam Zheng
2016-06-28 14:54 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 3/7] virtio: Introduce virtio_add_queue_aio Fam Zheng
2016-06-28 15:03 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 4/7] virtio: Use aio_set_event_notifier for aio vq Fam Zheng
2016-06-28 15:09 ` Stefan Hajnoczi
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio Fam Zheng
2016-06-28 15:12 ` Stefan Hajnoczi
2016-06-28 15:30 ` Paolo Bonzini
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 6/7] virtio-scsi: " Fam Zheng
2016-06-24 12:39 ` [Qemu-devel] [PATCH v2 7/7] Revert "mirror: Workaround for unexpected iohandler events during completion" Fam Zheng
2016-06-28 15:18 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628151804.GR2798@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).