From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHuoQ-0007wV-MQ for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:20:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHuoL-00050z-JQ for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:20:29 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:21015 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHuoL-00050u-CR for qemu-devel@nongnu.org; Tue, 28 Jun 2016 11:20:25 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5SFJGEt037484 for ; Tue, 28 Jun 2016 11:20:24 -0400 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 23skk10b73-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 28 Jun 2016 11:20:24 -0400 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 28 Jun 2016 16:20:22 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9B6262190068 for ; Tue, 28 Jun 2016 16:19:49 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5SFKJ124522462 for ; Tue, 28 Jun 2016 15:20:19 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u5SEKLGA006443 for ; Tue, 28 Jun 2016 08:20:21 -0600 Date: Tue, 28 Jun 2016 17:20:17 +0200 From: Cornelia Huck In-Reply-To: <57728C22.7010909@redhat.com> References: <20160624132906.14446-1-cornelia.huck@de.ibm.com> <20160624132906.14446-8-cornelia.huck@de.ibm.com> <57728C22.7010909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160628172017.35b57dc8.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 07/17] s390x/pci: introduce S390PCIBus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org, mst@redhat.com, borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com On Tue, 28 Jun 2016 17:39:30 +0300 Marcel Apfelbaum wrote: > On 06/24/2016 04:28 PM, Cornelia Huck wrote: > > From: Yi Min Zhao > > > > To enable S390PCIBusDevice as qdev, there should be a new bus to > > plug and manage all instances of S390PCIBusDevice. Due to this, > > S390PCIBus is introduced. > > > > Signed-off-by: Yi Min Zhao > > Reviewed-by: Pierre Morel > > Signed-off-by: Cornelia Huck > > --- > > hw/s390x/s390-pci-bus.c | 10 ++++++++++ > > hw/s390x/s390-pci-bus.h | 8 ++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > > index 0f6fcef..0c67c1e 100644 > > --- a/hw/s390x/s390-pci-bus.c > > +++ b/hw/s390x/s390-pci-bus.c > > @@ -527,6 +527,9 @@ static int s390_pcihost_init(SysBusDevice *dev) > > bus = BUS(b); > > qbus_set_hotplug_handler(bus, DEVICE(dev), NULL); > > phb->bus = b; > > + > > + s->bus = S390_PCI_BUS(qbus_create(TYPE_S390_PCI_BUS, DEVICE(s), NULL)); > > + > > QTAILQ_INIT(&s->pending_sei); > > return 0; > > } > > @@ -636,9 +639,16 @@ static const TypeInfo s390_pcihost_info = { > > } > > }; > > > > +static const TypeInfo s390_pcibus_info = { > > + .name = TYPE_S390_PCI_BUS, > > + .parent = TYPE_BUS, > > Hi, > > The type is named TYPE_S390_PCI_BUS, but does not > derive from PCI_BUS. I find it a little confusing, anyway is just a thought. > Maybe you should go with TYPE_S390_BUS. I think that would be even more confusing, as this is not the only bus on s390 :) I have trouble thinking of a better name, though. TYPE_S390PCI_BUS?