From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI5Q3-0005HH-TE for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI5Pz-0004Bz-Gu for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:40:02 -0400 Date: Wed, 29 Jun 2016 11:41:10 +1000 From: David Gibson Message-ID: <20160629014110.GA8885@voom.fritz.box> References: <1467126302-15604-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <1467126302-15604-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v0] spapr: Restore support for older PowerPC CPU cores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, thuth@redhat.com --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2016 at 08:35:02PM +0530, Bharata B Rao wrote: > Introduction of core based CPU hotplug for PowerPC sPAPR didn't > add support for 970 and POWER5+ based core types. Add support for > the same. >=20 > Signed-off-by: Bharata B Rao Applied to ppc-for-2.7 > --- > TODO: > - There are few other variants of 970, like 970fx etc for which I have not > added core types since I am not sure if they fall under sPAPR category. Yeah, frankly I wouldn't really trust the spapr code with anything except POWER7 or POWER8. > - Is it time to add core type for POWER8NVL yet ? Yes. > hw/ppc/spapr_cpu_core.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index 8b802a6..cebeef5 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -325,7 +325,6 @@ static void spapr_cpu_core_class_init(ObjectClass *oc= , void *data) > =20 > /* > * instance_init routines from different flavours of sPAPR CPU cores. > - * TODO: Add support for 'host' core type. > */ > #define SPAPR_CPU_CORE_INITFN(_type, _fname) \ > static void glue(glue(spapr_cpu_core_, _fname), _initfn(Object *obj)) \ > @@ -338,6 +337,8 @@ static void glue(glue(spapr_cpu_core_, _fname), _init= fn(Object *obj)) \ > core->cpu_class =3D oc; \ > } > =20 > +SPAPR_CPU_CORE_INITFN(970_v2.2, 970); > +SPAPR_CPU_CORE_INITFN(POWER5+_v2.1, POWER5plus); > SPAPR_CPU_CORE_INITFN(POWER7_v2.3, POWER7); > SPAPR_CPU_CORE_INITFN(POWER7+_v2.1, POWER7plus); > SPAPR_CPU_CORE_INITFN(POWER8_v2.0, POWER8); > @@ -349,6 +350,12 @@ typedef struct SPAPRCoreInfo { > } SPAPRCoreInfo; > =20 > static const SPAPRCoreInfo spapr_cores[] =3D { > + /* 970 */ > + { .name =3D "970", .initfn =3D spapr_cpu_core_970_initfn }, > + > + /* POWER5 */ > + { .name =3D "POWER5+", .initfn =3D spapr_cpu_core_POWER5plus_initfn = }, > + > /* POWER7 and aliases */ > { .name =3D "POWER7_v2.3", .initfn =3D spapr_cpu_core_POWER7_initfn = }, > { .name =3D "POWER7", .initfn =3D spapr_cpu_core_POWER7_initfn }, --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXcyc1AAoJEGw4ysog2bOS710QAJ7My52+G6ZPbbfnrNmpnHAo WKy28dmV4bFs4VihLLlCOOVr68bHsyXYwmHNAvUcwbjfKi00SlWai7XpyFMuzBbX FreGvYkZgyeK88W/et1WBVHY9G9FNfGcqZOnJUNpTzM/z0oFdRig7yEZ/q+AriVS NhBBc7AQkRufD7q6c/hrUbBNUipOrUgxnA6/+V+wNFP/alsHFr2GbDugZUbG2fRE d9WGinMh8APbMNtD8oFrIJdiO7dD5Lzj9kwJScSPDXJmd4DpUSVa7++wzQz9ubg/ 0jJl2H11Ryhi2oqksma7W/UAUUGT1wzw3nZ+gIaU5Fywr94jN3jc/pt+fRXN5mhB dyH4dQQaML6Lc6vjPZeK/OETCfa4Uf5dBut6WX0fWoLzkgWyQKIqNyE3BNGOZjuV FfTonuitWLXJgvUc65gKasQz6HLJf6qWU8NmuRkhKBvwy9DflDkUU0dOqHIa+s/z gZLj4zxED2mpyYvGuATfR3QrGKixTCPusdHkZkvrGZiypj4Oa1IVYovL14aTwQzZ mD49cDk28E0lpr6KrcNnPRcQU4StR5rd50yjZLXgQXynRDddm4MBRMpf+QHdSx4m h9eIqZMdFiMyZ8C9ntE/rrz+kvKwfFGwD+GT+zEuTZXrxT0afjLgEzzsVIA0oLEC UAJZhTJJF+nwhGj/Z+pW =OqGu -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--