From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI5Q1-0005H8-Sh for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI5Pz-0004C4-Gn for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:40:00 -0400 Date: Wed, 29 Jun 2016 11:42:51 +1000 From: David Gibson Message-ID: <20160629014251.GC8885@voom.fritz.box> References: <1467041915-19784-1-git-send-email-marcel@redhat.com> <1467041915-19784-2-git-send-email-marcel@redhat.com> <20160628025606.GT4242@voom.fritz.box> <57722E92.7010106@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WplhKdTI2c8ulnbP" Content-Disposition: inline In-Reply-To: <57722E92.7010106@redhat.com> Subject: Re: [Qemu-devel] [PATCH V5 1/5] hw/ppc: realize the PCI root bus as part of mac99 init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com, mst@redhat.com, davidkiarie4@gmail.com, peterx@redhat.com, bd.aviv@gmail.com, jan.kiszka@web.de, agraf@suse.de, qemu-ppc@nongnu.org, armbru@redhat.com --WplhKdTI2c8ulnbP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2016 at 11:00:18AM +0300, Marcel Apfelbaum wrote: > On 06/28/2016 05:56 AM, David Gibson wrote: > > On Mon, Jun 27, 2016 at 06:38:31PM +0300, Marcel Apfelbaum wrote: > > > Mac99's PCI root bus is not part of a host bridge, > > > realize it manually. > >=20 > > Um.. how did this ever work? >=20 > Well, the only thing the PCI bus realize does is > to register the VM migration state, so only migration was affected. >=20 > However, patch 2/5 adds to the realize function bus_master initialization= code > for all devices attached to the bridge. Ah, ok. In that case, ppc portions are Acked-by: David Gibson >=20 > Thanks, > Marcel >=20 > >=20 > > >=20 > > > Signed-off-by: Marcel Apfelbaum > > > --- > > > hw/ppc/mac_newworld.c | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c > > > index 32e88b3..7d25106 100644 > > > --- a/hw/ppc/mac_newworld.c > > > +++ b/hw/ppc/mac_newworld.c > > > @@ -380,6 +380,7 @@ static void ppc_core99_init(MachineState *machine) > > > pci_bus =3D pci_pmac_init(pic, get_system_memory(), get_sys= tem_io()); > > > machine_arch =3D ARCH_MAC99; > > > } > > > + object_property_set_bool(OBJECT(pci_bus), true, "realized", &err= or_abort); > > >=20 > > > machine->usb |=3D defaults_enabled() && !machine->usb_disabled; > > >=20 > >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --WplhKdTI2c8ulnbP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXcyebAAoJEGw4ysog2bOSrLkP/0A/7b59BPy6XxUu/dQPVUu7 XnzieSKCyDO9dWtmIbGSC9L1D2gcIiXVEYIJBQhIeTI9IUhqA9Uui0upAcHtitzc 3W0EPintsi6FXYR9w5K9MBrLhcRHhiocOtRG0mEDAuM+uG9N2eQCixZrQAc7mMpo R/yY2dVEpP+zlHdcLdCg90jmtUg9MnTgTo4+usov2fdQi9dCygYqPISTrMWe8kT/ oMt8APDVC+DBHuz9zZgnIldImHy+AyX9RFFCDxOFsAX7Rkov5l0n54DJ65UP+HoH uCZIOLDr2WUSUjTuIUnVJbDP7fCZm07W3FP/uy/vnkqxdwuNiBJA3HMcmPJS70Er FQoaPCw5r3DsSDaTDkhrfeYjWlF27GqIIYwPUUUv5kJx+OoabamzhigKtfSeHKVe djPIE7E2CFMUgDYh9XBrcUFecuM7AC6UiHdKpeBqPvjPIZlnv7dnhduxN2nwxLYH dMMJ408xqsmS++HBR1h7S/hYnSddEAJ8NgBcKqucvNEeSwQPvdzNruRWxXfD/dlP o0Yev6OfsryiFX+7WMN/F1XqdqscDnXZxQ79Ie1naggHIEAKZoTmfuTvB0z298fv Hj5O3vwPvU9yeyNoDKWD0kPcbMdoSJtamJpW3wKhvYCy1GcclECvXXAqhGLKFakp ELX/4CI5ou+Ai/ZGZF+8 =/Hh6 -----END PGP SIGNATURE----- --WplhKdTI2c8ulnbP--