From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI5dT-0003CT-M2 for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:53:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI5dR-0007C8-O5 for qemu-devel@nongnu.org; Tue, 28 Jun 2016 22:53:54 -0400 Date: Tue, 28 Jun 2016 22:53:45 -0400 From: Jeff Cody Message-ID: <20160629025345.GB10140@localhost.localdomain> References: <1466625064-11280-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466625064-11280-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com On Wed, Jun 22, 2016 at 03:51:01PM -0400, John Snow wrote: > e5b43573 caused a regression in the preparation of our IO vectors, such > that if a small granularity but a large buffer size is chosen, we may > accidentally exceed MAX_IOV and the request will fail. > > This has been fixed before in cae98cb8, and now we'll fix it again. > To keep it fixed, we'll add an iotest this time. > > [Thanks to Max for finding the root cause.] > > John Snow (3): > mirror: clarify mirror_do_read return code > mirror: limit niov to IOV_MAX elements, again > iotests: add small-granularity mirror test > > block/mirror.c | 10 ++++++++-- > tests/qemu-iotests/041 | 30 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/041.out | 4 ++-- > 3 files changed, 40 insertions(+), 4 deletions(-) > > -- > 2.4.11 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff