From: Jeff Cody <jcody@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments
Date: Tue, 28 Jun 2016 22:57:08 -0400 [thread overview]
Message-ID: <20160629025707.GD10140@localhost.localdomain> (raw)
In-Reply-To: <1466672241-22485-3-git-send-email-xiecl.fnst@cn.fujitsu.com>
On Thu, Jun 23, 2016 at 04:57:21PM +0800, Changlong Xie wrote:
> s/target bs/to_replace/, also we check to_replace bs is not
> blocked in qmp_drive_mirror() not here
>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index a04ed9c..4420a15 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -769,7 +769,7 @@ static void mirror_complete(BlockJob *job, Error **errp)
> }
> }
>
> - /* check the target bs is not blocked and block all operations on it */
> + /* block all operations on to_replace bs */
> if (s->replaces) {
> AioContext *replace_aio_context;
>
> --
> 1.9.3
>
>
>
next prev parent reply other threads:[~2016-06-29 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 8:57 [Qemu-devel] [PATCH v2 0/2] small fix of block job Changlong Xie
2016-06-23 8:57 ` [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job Changlong Xie
2016-06-29 2:56 ` Jeff Cody
2016-06-23 8:57 ` [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments Changlong Xie
2016-06-29 2:57 ` Jeff Cody [this message]
2016-06-23 9:30 ` [Qemu-devel] [PATCH v2 0/2] small fix of block job Fam Zheng
2016-06-24 10:07 ` Stefan Hajnoczi
2016-06-29 2:57 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629025707.GD10140@localhost.localdomain \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).